From nobody Fri Nov 10 18:00:41 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SRmpD1Tfvz50QBd for ; Fri, 10 Nov 2023 18:00:52 +0000 (UTC) (envelope-from joneum@FreeBSD.org) Received: from toco-domains.de (mail.toco-domains.de [IPv6:2a01:4f8:151:4202::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SRmpC0yQzz4HsX for ; Fri, 10 Nov 2023 18:00:51 +0000 (UTC) (envelope-from joneum@FreeBSD.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 2a01:4f8:151:4202::3 is neither permitted nor denied by domain of joneum@FreeBSD.org) smtp.mailfrom=joneum@FreeBSD.org; dmarc=none Received: from [192.168.188.37] (p579938da.dip0.t-ipconnect.de [87.153.56.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by toco-domains.de (Postfix) with ESMTPSA id 4357F21D7B1 for ; Fri, 10 Nov 2023 19:00:42 +0100 (CET) Content-Type: multipart/alternative; boundary="------------9Nlpw4WAPw3GOBzDcCmC8tX0" Message-ID: <4949e29a-dc01-4289-971d-0c61313fd463@FreeBSD.org> Date: Fri, 10 Nov 2023 19:00:41 +0100 List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-DE From: Jochen Neumeister To: freebsd-git@freebsd.org Subject: commit error: Non-standard/badly formatted template - found X-Spamd-Result: default: False [-1.08 / 15.00]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.99)[-0.989]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; XM_UA_NO_VERSION(0.01)[]; RCVD_COUNT_ONE(0.00)[1]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; R_SPF_SOFTFAIL(0.00)[~all:c]; FREEFALL_USER(0.00)[joneum]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[] X-Rspamd-Queue-Id: 4SRmpC0yQzz4HsX X-Spamd-Bar: - This is a multi-part message in MIME format. --------------9Nlpw4WAPw3GOBzDcCmC8tX0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi all, There is an error when I want to publish a commit: remote: remote: ================================================================ remote: Non-standard/badly formatted template - found 'Reviewers:' instead of 'Reviewed by:'. remote: ================================================================ remote: To ssh://repo.freebsd.org/ports.git I cannot find any errors in my commit message: databases/mysql57-{client, server}: Update to 5.7.43 Bugs Fixed: Group Replication: After one machine halted and restarted in a three-node MySQL InnoDB Cluster, one node failed to start; after restarting all nodes, the cluster shut down unexpectedly. Our thanks to Zetang Zeng for the contribution. (Bug #34976442) Fortified parsing of the network packet data sent by the server to the client. (Bug #35374491) Some floating-point literals were not always handled correctly. (Bug Executing a query with an implicit aggregation should return exactly one row, unless the query has a HAVING clause that filters out the row, but a query with a HAVING clause which evaluated to FALSE sometimes ignored this, and returned a row regardless. (Bug #14272020) During optimization, range-select tree creation uses logic which differs based on the left-hand side of the IN() predicate. For a field item, each value on the right-hand side is added to an OR tree to create the necessary expression. In the case of a row item comparison (example: WHERE (a,b) IN ((n1,m1), (n2, m2), ...)), an expression in disjunctive normal form (DNF) is needed. A DNF expression is created by adding an AND tree with column values to an OR tree for each set of RHS values, but instead the OR tree was added to the AND tree causing the tree merge to require exponential time due to O(n2) runtime complexity. (Bug See full Changlog here: https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-43.html Sponsored by:   Netzkommune GmbH # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # category/port: Subject goes here, max 50 cols -| # #                                                         72 columns --| # # Do not add a Submitted by line.  If someone besides the committer sent in the # change, the commit author should be set using `git commit --author`. # # Uncomment and complete these metadata fields, as appropriate: # # PR:           # Reported by:  # Reviewed by:  # Tested by:    # Approved by:  # Obtained from:        # Fixes:        # MFH:          # Relnotes:     # Security:     # Sponsored by: # Pull Request: # Differential Revision: # # "Pull Request" and "Differential Revision" require the *full* GitHub or # Phabricator URL. # # Date:      Fri Nov 10 18:25:02 2023 +0100 # # On branch main # Your branch is ahead of 'origin/main' by 2 commits. #   (use "git push" to publish your local commits) # # Changes to be committed: #       modified: databases/mysql57-client/files/patch-cmake_ssl.cmake #       modified:   databases/mysql57-server/Makefile #       modified:   databases/mysql57-server/distinfo #       modified: databases/mysql57-server/files/patch-cmake_ssl.cmake I have set up my git according to this guideline: https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use Does anyone here have any tips? Cheers jochen --------------9Nlpw4WAPw3GOBzDcCmC8tX0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi all,

There is an error when I want to publish a commit:

remote:
remote: ================================================================
remote: Non-standard/badly formatted template - found 'Reviewers:' instead of 'Reviewed by:'.
remote: ================================================================
remote:
To ssh://repo.freebsd.org/ports.git

I cannot find any errors in my commit message:

databases/mysql57-{client, server}: Update to 5.7.43

Bugs Fixed:
Group Replication: After one machine halted and restarted in a
three-node MySQL InnoDB Cluster, one node failed to start; after
restarting all nodes, the cluster shut down unexpectedly.

Our thanks to Zetang Zeng for the contribution. (Bug #34976442)

Fortified parsing of the network packet data sent by the server to
the client. (Bug #35374491)

Some floating-point literals were not always handled correctly. (Bug

Executing a query with an implicit aggregation should return exactly
one row, unless the query has a HAVING clause that filters out the row,
but a query with a HAVING clause which evaluated to FALSE sometimes
ignored this, and returned a row regardless. (Bug #14272020)

During optimization, range-select tree creation uses logic which
differs based on the left-hand side of the IN() predicate. For a field
item, each value on the right-hand side is added to an OR tree to create
the necessary expression. In the case of a row item comparison (example:
WHERE (a,b) IN ((n1,m1), (n2, m2), ...)), an expression in disjunctive
normal form (DNF) is needed. A DNF expression is created by adding an
AND tree with column values to an OR tree for each set of RHS values,
but instead the OR tree was added to the AND tree causing the tree merge
to require exponential time due to O(n2) runtime complexity. (Bug

See full Changlog here: https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-43.html

Sponsored by:   Netzkommune GmbH

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# category/port: Subject goes here, max 50 cols -|
# <then a blank line>
#                                                         72 columns --|
#
# Do not add a Submitted by line.  If someone besides the committer sent in the
# change, the commit author should be set using `git commit --author`.
#
# Uncomment and complete these metadata fields, as appropriate:
#
# PR:           <If and which Problem Report is related.>
# Reported by:  <If someone else reported the issue.>
# Reviewed by:  <If someone else reviewed your modification.>
# Tested by:    <If someone else tested the change.>
# Approved by:  <If you needed approval for this commit.>
# Obtained from:        <If the change is from a third party.>
# Fixes:        <Short hash and title line of commit fixed by this change>
# MFH:          <Ports tree branch name you plan to merge to.>
# Relnotes:     <Set to 'yes' for mention in release notes.>
# Security:     <Vulnerability reference (one per line) or description.>
# Sponsored by: <If the change was sponsored by an organization.>
# Pull Request: <https://github.com/freebsd/freebsd-ports/pull/###>
# Differential Revision:        <https://reviews.freebsd.org/D###>
#
# "Pull Request" and "Differential Revision" require the *full* GitHub or
# Phabricator URL.
#
# Date:      Fri Nov 10 18:25:02 2023 +0100
#
# On branch main
# Your branch is ahead of 'origin/main' by 2 commits.
#   (use "git push" to publish your local commits)
#
# Changes to be committed:
#       modified:   databases/mysql57-client/files/patch-cmake_ssl.cmake
#       modified:   databases/mysql57-server/Makefile
#       modified:   databases/mysql57-server/distinfo
#       modified:   databases/mysql57-server/files/patch-cmake_ssl.cmake

I have set up my git according to this guideline: https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use

Does anyone here have any tips?


Cheers
jochen


--------------9Nlpw4WAPw3GOBzDcCmC8tX0--