From nobody Fri Jan 28 15:53:56 2022 X-Original-To: gecko@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B22F0198F876 for ; Fri, 28 Jan 2022 15:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JlhpF3q7vz4mBp for ; Fri, 28 Jan 2022 15:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 639A52CEBC for ; Fri, 28 Jan 2022 15:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 20SFrvd0060040 for ; Fri, 28 Jan 2022 15:53:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 20SFrvJE060039 for gecko@FreeBSD.org; Fri, 28 Jan 2022 15:53:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: [Bug 261410] www/firefox: Update to 96.0.3 (unfixed security vulnerabilities) Date: Fri, 28 Jan 2022 15:53:56 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, security X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Gecko Rendering Engine issues List-Archive: https://lists.freebsd.org/archives/freebsd-gecko List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gecko@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643385237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MovQCKC/EZ3iDLvQkpKc/pTc8wlvng0qH/OLIyEouZk=; b=g37zz2kTQWKL3CP01wylKTJUOT6DJW3ckxBFkpVfkw4jg6AsG92syBebYYujuv5lu0m3QE 5gpd0+tqBaDZYL9dAVvOX+lwT6/1VtHjtseO2Y9XFdB/wVVjKua15bk/yQ6FSv/b7joHJ6 EsiFwySigPeHkrP+aXUAyp1N7KmYd6PEtK0HCkwoF0cgzJzA3zXeHr4CqPeFoCm9+xfmWm armwZ9Oz4RSKVIUSFEF0Ir7dIwHISy2S2TWIgf+EZAuqMjMMCzqw0yKOa0wpLkng/vFHyt AFaRomKV2ACUuEUisyhzzUYrGHe9EY1EcSJRSyTb0hmPZI1vg3nltsW5NZhE1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643385237; a=rsa-sha256; cv=none; b=t2igVyvBBzLTFg9DPgFfpiEYB8JfqkG1D1f7gXbigPUuhhavEaEpoCVcl7nNUfOprqNuF/ Fs/RHVOR728z12aNYasFBvR/RewmfBz38g7b/p+8HgmCf4XZCLKqpjS9Xtfxq4Ut8WHXhH oaOHtLSGwV+ix+T/YQSXLcVi+fiNobEAcPHB5hwt+xsUak1ShJ/tdn2lkvKt4hU9LS4m1e 0ys/Ksap2/3ogw3iwpnHfRAMkuaCYv1yOEZ6/aueCp09Ftpthxj7g93qLZrMsp4Q3Kg7nt aOjtSeXW3WgPS9puxmmaHtdGdXgdyypfJuecPzwHUkoo5YR1OhQ8hpfi21qfGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261410 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #231401|maintainer-approval?(gecko@ |maintainer-approval+ Flags|FreeBSD.org) | --- Comment #11 from Jan Beich --- Comment on attachment 231401 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D231401 v1.0 (zstd, git) Awesome work! Looks generally fine. Some nitpicks: > - harfbuzz>=3D2.9.1:print/harfbuzz \ > + harfbuzz>=3D2.7.4:print/harfbuzz \ Firefox 96 bundles harfbuzz 3.1.2, so the version check in files/patch-bug847568 is stale https://searchfox.org/mozilla-release/rev/713683b4a6b0/gfx/harfbuzz/src/hb-= version.h > - libvpx>=3D1.8.2:multimedia/libvpx \ > + libvpx>=3D1.8.0:multimedia/libvpx \ Firefox 96 bundles libvpx 1.8.2, so upstream version check in toolkit/moz.configure is stale https://searchfox.org/mozilla-release/rev/713683b4a6b0/media/libvpx/config/= vpx_version.h > -index 75c2c5e435e35..4d8c09c02759b 100644 > +index af08811..77a3b18 100644 (Cosmetic) "git add -p" makes it easy to skip such noise. > -@@ -39,7 +39,7 @@ pref("extensions.postDownloadThirdPartyPrompt", true); > +@@ -38,7 +38,7 @@ pref("extensions.postDownloadThirdPartyPrompt", true); (Cosmetic) When only offset changes but context (surrounding lines) remains= the same regenerating diffs can be skipped. > diff --git gfx/2d/DrawTargetSkia.cpp gfx/2d/DrawTargetSkia.cpp (Cosmetic) Sorting by Git kinda obfuscates what has really changed. > +--- config/makefiles/rust.mk.orig 2020-05-12 09:36:22 UTC (Cosmetic) Don't keep garbage from the old version. > +Subject: [PATCH] Backport OpenBSD changes from 97 and WEBRTC_BSD, regen > + gn+manifest for amd64 and i386 (actually, i686 with -msse2) PkgSrc version for comparison: https://github.com/NetBSD/pkgsrc/blob/5261ee98811c/www/firefox/patches/patc= h-libwebrtc.diff Curiously, Firefox < 96 had x64*dragonfly.json but wasn't used due to https://github.com/DragonFlyBSD/DeltaPorts/commit/92611d22ee0d > dom/media/webrtc/third_party_build/gn-configs/x64_False_x64_freebsd.json gn-configs/ and BUILD.gn aren't used during Firefox build, only to generate moz.build in a separate step. Dropping those will shrink patch-webrtc by 92% i.e., from 9.7 MiB to 698 KiB > ++ # Comment-out rustup on aarch64; no binary rustup for FreeBSD/aarch64 Confusing wording. "Comment-out" -> "Commented out" and ";" -> ":" i686 works on x86_64 via rustup due to /usr/lib32 but aarch64 libs aren't installed on x86_64 by default. Partial --sysroot can help e.g., $ fetch https://pkg.freebsd.org/FreeBSD:14:aarch64/latest/All/rust-1.58.0= .pkg $ tar xf rust-1.58.0.pkg $ cp -a ./usr/local/lib/rustlib/*-unknown-freebsd /usr/local/lib/rustlib/ $ echo 'fn main() {}' >foo.rs $ rustc --target=3Daarch64-unknown-freebsd foo.rs error: linking with `cc` failed: exit status: 1 [...] =3D note: ld: error: foo.foo.32c0c825-cgu.0.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.foo.32c0c825-cgu.1.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.foo.32c0c825-cgu.2.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.foo.32c0c825-cgu.3.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.foo.32c0c825-cgu.4.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.foo.32c0c825-cgu.5.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.foo.32c0c825-cgu.6.rcgu.o is incompatible with /usr/lib/Scrt1.o ld: error: foo.50rnet0thytpgybx.rcgu.o is incompatible with /usr/lib/Scrt1.o cc: error: linker command failed with exit code 1 (use -v to see invocation) $ rustc -C link-args=3D"--sysroot /poudriere/jails/main-aarch64" --target=3Daarch64-unknown-freebsd foo.rs $ file foo foo: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, FreeBSD-style, with debug_info, not stripped $ cargo new --bin bar $ cd bar $ export RUSTFLAGS=3D'-C link-arg=3D--sysroot -C link-arg=3D/poudriere/jails/main-aarch64 --target=3Daarch64-unknown-freebsd' $ cargo build $ file target/debug/bar target/debug/bar: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, FreeBSD-st= yle, with debug_info, not stripped --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=