[Bug 278494] Hang during boot after recent ZFS update in CURRENT
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 21 Apr 2024 07:39:11 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278494
--- Comment #6 from Kyle Ambroff-Kao <kyle@ambroffkao.com> ---
I think I see the bug. Note that this comment says that it skips handling
faults on device open *or flush*, but it is checking for IOCTL not FLUSH in
that if condition.
--- a/module/zfs/zio_inject.c
+++ b/module/zfs/zio_inject.c
@@ -364,10 +364,10 @@ zio_handle_device_injection_impl(vdev_t *vd, zio_t *zio,
int err1, int err2)
int ret = 0;
/*
- * We skip over faults in the labels unless it's during
- * device open (i.e. zio == NULL).
+ * We skip over faults in the labels unless it's during device open
+ * (i.e. zio == NULL) or a device flush (offset is meaningless)
*/
- if (zio != NULL) {
+ if (zio != NULL && zio->io_type != ZIO_TYPE_IOCTL) {
uint64_t offset = zio->io_offset;
if (offset < VDEV_LABEL_START_SIZE ||
This is changed upstream in a later change
https://github.com/openzfs/zfs/commit/d7605ae77b7ad176e8dbd5649fe4d14f5f4e8b9f
I'll confirm that this is the issue.
--
You are receiving this mail because:
You are the assignee for the bug.