[Bug 270089] mpr: panic in mpr_complete_command during zpool import

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270089

--- Comment #18 from Dan Kotowski <dan.kotowski@a9development.com> ---
As it turns out my drives do not support NCQed TRIM. This was fixed for ada by
review D43961 but not for da.

From base b7dce5b "scsi_da: add 4K quirks for Samsung SSD 860 and 870":
```
diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
index d578e4ccb712..9b3d706d6168 100644
--- a/sys/cam/scsi/scsi_da.c
+++ b/sys/cam/scsi/scsi_da.c
@@ -1397,6 +1397,22 @@ static struct da_quirk_entry da_quirk_table[] =
        },
        {
                /*
+                * Samsung 860 SSDs
+                * 4k optimised & trim only works in 4k requests + 4k aligned
+                */
+               { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "Samsung SSD 860*", "*" },
+               /*quirks*/DA_Q_4K
+       },
+       {
+               /*
+                * Samsung 870 SSDs
+                * 4k optimised & trim only works in 4k requests + 4k aligned
+                */
+               { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "Samsung SSD 870*", "*" },
+               /*quirks*/DA_Q_4K
+       },
+       {
+               /*
                 * Samsung 843T Series SSDs (MZ7WD*)
                 * Samsung PM851 Series SSDs (MZ7TE*)
                 * Samsung PM853T Series SSDs (MZ7GE*)
```

From base c01af41 "ata_da: add quirk to disable NCQ TRIM for Samsung 860/870
SSDs":
```
diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c
index f5d3aeca9329..d4a591943307 100644
--- a/sys/cam/ata/ata_da.c
+++ b/sys/cam/ata/ata_da.c
@@ -729,6 +729,22 @@ static struct ada_quirk_entry ada_quirk_table[] =
        },
        {
                /*
+                * Samsung 860 SSDs
+                * 4k optimised, NCQ TRIM broken (normal TRIM fine)
+                */
+               { T_DIRECT, SIP_MEDIA_FIXED, "*", "Samsung SSD 860*", "*" },
+               /*quirks*/ADA_Q_4K | ADA_Q_NCQ_TRIM_BROKEN
+       },
+       {
+               /*
+                * Samsung 870 SSDs
+                * 4k optimised, NCQ TRIM broken (normal TRIM fine)
+                */
+               { T_DIRECT, SIP_MEDIA_FIXED, "*", "Samsung SSD 870*", "*" },
+               /*quirks*/ADA_Q_4K | ADA_Q_NCQ_TRIM_BROKEN
+       },
+       {
+               /*
                 * Samsung SM863 Series SSDs (MZ7KM*)
                 * 4k optimised, NCQ believed to be working
                 */
```

At least some of my affected drives are in the Samsung SSD 860 family.

I do not see anything like NCQ_TRIM_BROKEN in scsi_da.c and we would probably
need to implement there.

-- 
You are receiving this mail because:
You are the assignee for the bug.