From nobody Mon Jan 09 15:02:08 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NrHGn2qbJz2sFgh for ; Mon, 9 Jan 2023 15:02:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NrHGm5QFCz3sTP for ; Mon, 9 Jan 2023 15:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673276528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYHRTiuvFm8rnsPyIDYegO2GhB6RInNmFgxeMtDpp2M=; b=hXBOYIlE+De3pvzt+PVy0WMY7nhG6AW7+RsLv7+rBy8pbbKzXREaq5CGKAHVlEX+DldhMC vmgj5zuDnrOT6RsC+Xi6xOA2IB+hAmnEJnqnrxmqEVXBVdz2FFxylj7zCd7w7kQNJ2UzGw SIKffjIuPd05C8RsanV2mQ/1AsYeyV2SuKG/d0OIU5bZ2Pla/43iIAyMxzT8v6jx46wHyu 3kwnpSxsGTkXSxDaZinhBq60VUoFvIVPNgi/gApg64rZKW6wWkgJbsw4bqXMGxXfecvpvC 6ifxkmz4t+P7CJnL7qwdu+bCbEKNkt7t1eYrmS7YFga+ShEcr/FmR+OijBOweg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673276528; a=rsa-sha256; cv=none; b=NgJ7lFkIp1h50S4NHz07gyw5T99AGkTD6jtgwaNvjVX5W5jpQOiQ6COlYiqbut24xentoh DH1NTfQPekyshxzRolZGIpiYpzw4JJr7fxj8ayqn2KhI9uoRInLP6oYcsUebF8qgMQSJBS GyTB1ktuxnJ1C2KGB2kuwNIpBZT4l4cfOk1ICEY7RgsYmtwH3obb0Ex3HVmEVaR27MXkd8 XwxSTeiHKmgHa1QTfL+8ZXsiEIGKkWJjpEWGJ+epFlNbdSjBfwmAKuKZgvDSI2x00P+x+O c3BFTylj/vvRIdP2tMCYGIHacY/yoXN9folx98RrYyXkqfMc2RI0af8iSBeVyQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NrHGm4WSbzXY7 for ; Mon, 9 Jan 2023 15:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 309F28BA077198 for ; Mon, 9 Jan 2023 15:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 309F28DV077197 for fs@FreeBSD.org; Mon, 9 Jan 2023 15:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 251342] fs/unionfs: VOP_UNSET_TEXT without VOP_SET_TEXT leads to panic Date: Mon, 09 Jan 2023 15:02:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251342 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D04f8674aa7486ec2d73d60c2247fe5e33= b5399c5 commit 04f8674aa7486ec2d73d60c2247fe5e33b5399c5 Author: Jason A. Harmening AuthorDate: 2021-12-21 23:51:51 +0000 Commit: Ed Maste CommitDate: 2023-01-09 02:31:15 +0000 unionfs: implement VOP_SET_TEXT/VOP_UNSET_TEXT The implementation simply passes the text ref to the appropriate underlying vnode. Without this, the default [un]set_text implementation will only manage the text ref on the unionfs vnode, causing it to be out of sync with the underlying filesystems and potentially allowing corruption of executable file contents. On INVARIANTS kernels, it also readily produces a panic on process termination because the VM object representing the executable mapping is backed by the underlying vnode, not the unionfs vnode. PR: 251342 Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D33611 (cherry picked from commit 9e891d43f586e91541bd61fb12550de296d76fd9) sys/fs/unionfs/union_vnops.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=