From nobody Tue Feb 28 20:44:14 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PR8VQ6kvpz3tvxn for ; Tue, 28 Feb 2023 20:44:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PR8VQ3xSWz3xpj for ; Tue, 28 Feb 2023 20:44:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677617054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GydCrBB2Eqp7J1uUmbZcnCwFbg2aNMJJ1HNpfGWO7Fs=; b=hGn8Jxa589gOzcx9/zhHob1KfsWNDHQR+E+F70kfhn7/MrPUHCOwyBdbnbhVEeCNgXnTvm G9REBeYwYUcnMOIwPvI/tiENIhIRorldO76EgiRc8rmYo1SMn2C+8gc4lo78ZU9G2ROf7A FWN9Idgl76Sehliv4T1As+5G/lNOa0S0QRdqTz8m7HsaetkbVQGua96DbywRApuHXCqnM3 0TErlS6P2HG8IldjPZHxZUtP3suUwwPUCWf5zEEhd62KTYmQnIKqftf7k9iL/XAj8lj/6b erZ48tb7ud78Q/k1JpvcHSdJd3PS5snojXrIrbxLqmlQOXKaqWlY5FIAnfrVVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677617054; a=rsa-sha256; cv=none; b=enbpkmtYQLNJG6JFhiadjkoe4/qIYOoE5Dhp9tuYXj8g1zK5g3m8Kwbukd7tiKFZ6bRhIP emHkhF+JPz8NoMRzSK2DZYi4Gx6AVhcIX71JQA5H6LgQK5Y3dRCkBL8MS+9+371M3/xRal +pT54qQU9UUb1qph3OujwZNYqEfKg2sYlGLmdjJ+P4yhTEbeqhll+WYPdTjdI30ypInlY6 iOqOgnNO/bHnKPDFKP74QaCEKdpqQq3k0P5+aXfFJTiOTIZf1EtQAOl1o+9GrAyzhhWNyi VsJJ6GrfawlcAFvcPsWqbla4PRWGndH5V4YZ3dK/K3TUgV3HcX5ixIi6407fVw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PR8VQ32d4z1M1y for ; Tue, 28 Feb 2023 20:44:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31SKiELA047042 for ; Tue, 28 Feb 2023 20:44:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31SKiEQ0047041 for fs@FreeBSD.org; Tue, 28 Feb 2023 20:44:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 106107] UFS: fsck_ffs: left-over fsck_snapshot after unfinished background fsck if filesystem clean Date: Tue, 28 Feb 2023 20:44:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 6.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D106107 --- Comment #13 from Kirk McKusick --- (In reply to Mark Millard from comment #12) The open of the snapshot also includes the reading of the superblock on the snapshot. Until recently rather few checks were done, so a bad field in the superblock could create a wild pointer that would cause fsck to segment fau= lt. So that would be my best guess of what caused the premature exit with the snapshot still in place. I should reorganize the code to do the unlink immediately after the open to close that window. --=20 You are receiving this mail because: You are the assignee for the bug.=