Lock order reversals (LOR) for ufs,devfs,nullfs

From: Artem Kuchin <artem_at_artem.ru>
Date: Fri, 17 Feb 2023 01:00:33 UTC
I see LORs on every boot and at shutdown.Is it bad?

13-STABLE


Feb 17 03:55:44 omni kernel: lock order reversal:
Feb 17 03:55:44 omni kernel:  1st 0xfffff8001d9f2258 ufs (ufs, lockmgr) 
@ /usr/src/sys/kern/vfs_mount.c:1062
Feb 17 03:55:44 omni kernel:  2nd 0xfffff8001d8309f8 devfs (devfs, 
lockmgr) @ /usr/src/sys/kern/vfs_mount.c:1074

Feb 17 03:55:44 omni kernel: lock order devfs -> ufs established at:
Feb 17 03:55:44 omni kernel: #0 0xffffffff80cab8cd at 
witness_checkorder+0x32d
Feb 17 03:55:44 omni kernel: #1 0xffffffff80c0ccf2 at 
lockmgr_lock_flags+0x182
Feb 17 03:55:44 omni kernel: #2 0xffffffff80fa98ac at ffs_lock+0x6c
Feb 17 03:55:44 omni kernel: #3 0xffffffff80d3a174 at _vn_lock+0x54
Feb 17 03:55:44 omni kernel: #4 0xffffffff80d1ccaf at vfs_domou
Feb 17 03:55:44 omni kernel: nt_first+0x58f
Feb 17 03:55:44 omni kernel: #5 0xffffffff80d196b4 at vfs_domount+0x2d4
Feb 17 03:55:44 omni kernel: #6 0xffffffff80d18585 at vfs_donmount+0x895
Feb 17 03:55:44 omni kernel: #7 0xffffffff80d1bcd3 at kernel_mount+0x63
Feb 17 03:55:44 omni kernel: #8 0xffffffff80d1f984 at parse_mount+0x4d4

Feb 17 03:55:44 omni kernel: 9 0xffffffff80d1dfc3 at vfs_mountroot+0x7c3
Feb 17 03:55:44 omni kernel: #10 0xffffffff80bcae03 at start_init+0x23
Feb 17 03:55:44 omni kernel: #11 0xffffffff80bf7f40 at fork_exit+0x80
Feb 17 03:55:44 omni kernel: #12 0xffffffff8110bf2e at fork_trampoline+0xe

Feb 17 03:55:44 omni kernel: lock order ufs -> devfs attempted at:
Feb 17 03:55:44 omni kernel: #0 0xffffffff80cac19d at witness_checkord
Feb 17 03:55:44 omni kernel: er+0xbfd
Feb 17 03:55:44 omni kernel: #1 0xffffffff80c0e725 at lockmgr_xlock+0x55
Feb 17 03:55:44 omni kernel: #2 0xffffffff80d3a174 at _vn_lock+0x54
Feb 17 03:55:44 omni kernel: #3 0xffffffff80d1ccaf at vfs_domou
Feb 17 03:55:44 omni kernel: nt_first+0x58f
Feb 17 03:55:44 omni kernel: #4 0xffffffff80d196b4 at vfs_domount+0x2d4
Feb 17 03:55:44 omni kernel: #5 0xffffffff80d18585 at vfs_donmount+0x895
Feb 17 03:55:44 omni kernel: #6 0xffffffff80d17cb9 at sys_nmount+0x69
Feb 17 03:55:44 omni kernel: #7 0xffffffff8113752e at amd64_syscall+0x12e
Feb 17 03:55:44 omni kernel: #8 0xffffffff8110b7cb at 
fast_syscall_common+0xf8

Feb 17 03:55:50 omni kernel: lock order reversal:
Feb 17 03:55:50 omni kernel:  1st 0xfffff8001dc0b810 ufs (ufs, lockmgr) 
@ /usr/src/sys/kern/vfs_subr.c:3043
Feb 17 03:55:50 omni kernel:  2nd 0xfffff8001dc0b628 nullfs (nullfs, 
lockmgr) @ /usr/src/sys/fs/nullfs/null_vnops.c:913
Feb 17 03:55:50 omni kernel:  3rd 0xfffff80003b6b810 ufs (ufs, lockmgr) 
@ /usr/src/sys/ufs/ufs/ufs_quota.c:1596

Feb 17 03:55:50 omni kernel: lock order ufs -> nullfs established at:
Feb 17 03:55:50 omni kernel: #0 0xffffffff80cab8cd at 
witness_checkorder+0x32d
Feb 17 03:55:50 omni kernel: #1 0xffffffff80c0d3db at 
lockmgr_xlock_hard+0x6b
Feb 17 03:55:50 omni kernel: #2 0xffffffff80c0dcd9 at __lockmgr_args+0x1f9
Feb 17 03:55:50 omni kernel: #3 0xffffffff825abb80 at null_reclaim+0x60
Feb 17 03:55:50 omni kernel: #4 0xffffffff81208914 at VOP_RECLAIM_APV+0x34
Feb 17 03:55:50 omni kernel: #5 0xffffffff80d25f84 at vgonel+0x3b4
Feb 17 03:55:50 omni kernel: #6 0xffffffff80d2664e at vrecycle+0x3e
Feb 17 03:55:50 omni kernel: #7 0xffffffff825abac0 at null_inactive+0x40
Feb 17 03:55:50 omni kernel: #8 0xffffffff80d250bf at vinactivef+0xbf
Feb 17 03:55:50 omni kernel: #9 0xffffffff80d248f7 at vput_final+0x2a7
Feb 17 03:55:50 omni kernel: #10 0xffffffff80d31f05 at kern_funlinkat+0x235
Feb 17 03:55:50 omni kernel: #11 0xffffffff80d31cc8 at sys_unlink+0x28
Feb 17 03:55:50 omni kernel: #12 0xffffffff8113752e at amd64_syscall+0x12e
Feb 17 03:55:50 omni kernel: #13 0xffffffff8110b7cb at 
fast_syscall_common+0xf8

Feb 17 03:55:50 omni kernel: lock order nullfs -> ufs attempted at:
Feb 17 03:55:50 omni kernel: #0 0xffffffff80cac19d at 
witness_checkorder+0xbfd
Feb 17 03:55:50 omni kernel: #1 0xffffffff80c0ccf2 at 
lockmgr_lock_flags+0x182
Feb 17 03:55:50 omni kernel: #2 0xffffffff80fa98ac at ffs_lock+0x6c
Feb 17 03:55:50 omni kernel: #3 0xffffffff80d3a174 at _vn_lock+0x54
Feb 17 03:55:50 omni kernel: #4 0xffffffff80fb630a at dqsync+0x14a
Feb 17 03:55:50 omni kernel: #5 0xffffffff80fb6632 at qsyncvp+0x52
Feb 17 03:55:50 omni kernel: #6 0xffffffff80fb0e2e at ufs_inactive+0x3e
Feb 17 03:55:50 omni kernel: #7 0xffffffff80d250bf at vinactivef+0xbf
Feb 17 03:55:50 omni kernel: #8 0xffffffff80d248f7 at vput_final+0x2a7
Feb 17 03:55:50 omni kernel: #9 0xffffffff825abc16 at null_reclaim+0xf6
Feb 17 03:55:50 omni kernel: #10 0xffffffff81208914 at VOP_RECLAIM_APV+0x34
Feb 17 03:55:50 omni kernel: #11 0xffffffff80d25f84 at vgonel+0x3b4
Feb 17 03:55:50 omni kernel: #12 0xffffffff80d2664e at vrecycle+0x3e
Feb 17 03:55:50 omni kernel: #13 0xffffffff825abac0 at null_inactive+0x40
Feb 17 03:55:50 omni kernel: #14 0xffffffff80d250bf at vinactivef+0xbf
Feb 17 03:55:50 omni kernel: #15 0xffffffff80d248f7 at vput_final+0x2a7
Feb 17 03:55:50 omni kernel: #16 0xffffffff80d31f05 at kern_funlinkat+0x235
Feb 17 03:55:50 omni kernel: #17 0xffffffff80d31cc8 at sys_unlink+0x28


Regards,

Artem