From nobody Mon Feb 13 22:32:11 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFzbv4bM8z3qWG5 for ; Mon, 13 Feb 2023 22:32:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFzbv3PS5z3GV2 for ; Mon, 13 Feb 2023 22:32:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676327531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMdlQpjPyr/aSbMgBUHYeEVVZ8au7XEcIDwjuQYz3ZQ=; b=faP2qm7V0CNSvEyVyzIiu6yjvn7Q6LuVWeF1zM8FYlW+GY8vVICvDDUYi/YmDiKT6PlcHA PSsA6Mqep0kVI/i1jDLWTQfuflv4Zui8I1GO7US71S4o2vM2phPg5UtJrpYfwmUdvI5wR5 SLoBlHBsZ5MioPoQoqkOjUbmoY5n2GTu9jXuTGcJIUMugr1Xi6fRDcd0MQe0qmP5pDDVWd /qJkAlZWRG1WjzzIOmDuZNH1TjAt9JuWDf8fNc/mMi2z51jUIPZ34IYRwH4pxQQXo9G6D+ SxC9QrsaV9PEEewUj0AR7pPF8V1mFWAK6qdFvG5+6pEvYsEe9GXW18i1Y24IXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676327531; a=rsa-sha256; cv=none; b=N3s+WXIesb31osSCVzxXIOOcQn6OzAPaOwXvlWrM9wZfbCjYJhKDUHONB3PUOyFMx88yqA +CydJ9EQ3MJTB9h4Pno7TxZgcZJ4bqifS0G+ntKFggUu4o+4RTzdRrvWwplrqD0A4T9hYl ok2TIMTue7+Jyn5Fl6x0v2dMn2fjutl5BF+3CJ129L81zfs3BSJnB/CUGccqqOSGTPfKnc Q7rC5Yi/8xX9yUNWR3YRcRQ8v2PhyGwqKp6BHjUhd3HhBMaLc3TbbBjmZZZHdfWWLZ3AHR 2Xy0nWevXRQT5ziBHcoB8uga0N1GQLvmeNU/EpqQ6JwygdeM9P892ifP2JYvGQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PFzbv2V9WzbV3 for ; Mon, 13 Feb 2023 22:32:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31DMWBsp054210 for ; Mon, 13 Feb 2023 22:32:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31DMWBea054209 for fs@FreeBSD.org; Mon, 13 Feb 2023 22:32:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 269341] [msdosfs] deadlock with sendfile Date: Mon, 13 Feb 2023 22:32:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269341 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0152d453a08fa2bad694dc04a8184fce2= b7faa10 commit 0152d453a08fa2bad694dc04a8184fce2b7faa10 Author: Konstantin Belousov AuthorDate: 2023-02-11 18:09:30 +0000 Commit: Konstantin Belousov CommitDate: 2023-02-13 22:29:42 +0000 msdosfs deextend: validate pages of the partial buffer Suppose that the cluster size is larger than page size. If the buffer at the old EOF (before extending) was partial and dirty, it cannot be automatically neither written out nor validated by the buffer cache, since extending buffer adds invalid pages at the end. Correct the buffer state by calling vfs_bio_clrbuf() on it, to mark newly added and zeroed pages as valid. Note that UFS is immune to the problem because ffs_truncate() always allocate the block and buffer for the last byte of the file. PR: 269341 Reported by: asomers In collaboration with: pho Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D38549 sys/fs/msdosfs/msdosfs_denode.c | 36 +++++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=