From nobody Mon Oct 17 01:01:26 2022 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MrJbm31h5z4fKS3 for ; Mon, 17 Oct 2022 01:01:40 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MrJbl4CyPz3kwp for ; Mon, 17 Oct 2022 01:01:39 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-vs1-f41.google.com with SMTP id 1so5800719vsx.1 for ; Sun, 16 Oct 2022 18:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R+H31Z1EwFpWC53exa7ujdwM8ATvKLrJeQnXZOxKkq4=; b=OpINQiLGY3rEgFaGBcTcScfyv5j9rV1X1ZHJwwm1nSY7+lDgkHd8xr1QvH7Ftr14av GluS6t/u9ypO582t0n5ovkmNOThgjgGqLxnBT9jdcR2zQKbLyhukmyWGptZDoh6N9J/M V39cWwpXVl5Wp9+T7q+u9Wlb1tMqYiJpPDbnWsN1P07bWb49bMc56C6Vf/8FyYNfqnEr J2Lw+PU2LfkA9BmuaF4cJ9H+AkvuTrQyABUcuJRAyHazqo/dzyDh8qm+RqMAaHeoJxgq ykGRLP2vaF/eFNYqcHDKCLkla505GX+DSCc7sKXJNKf4V2HSlYUdl4+dYEu+qHJ7fJSv /6gQ== X-Gm-Message-State: ACrzQf1rtIT4kJveIjMOEstkEXN3PiGM4qqOE7aDfm35oMQflzb2zKpB BkUO4aATbcLdXbdWzkC4Hq8OZKhEaD81fL7vTYw= X-Google-Smtp-Source: AMsMyM5Llcnp9ufxdUqaH3F2BH0S6YIuv/eMIkHIb8nz6UYzTF4RAdjHf5IXS3EF+hUcWKX3f051IDhCgI5GmdIOyOU= X-Received: by 2002:a05:6102:9d7:b0:3a6:fdeb:3bcc with SMTP id g23-20020a05610209d700b003a6fdeb3bccmr3148790vsi.53.1665968498283; Sun, 16 Oct 2022 18:01:38 -0700 (PDT) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Sun, 16 Oct 2022 19:01:26 -0600 Message-ID: Subject: Re: RFC: ZFS does not update ctime/va_filerev upon Setextattr/rmextattr To: Rick Macklem Cc: FreeBSD Filesystems Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4MrJbl4CyPz3kwp X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.993]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-fs@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.217.41:from]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.217.41:from]; TO_DN_ALL(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[asomers]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Sun, Oct 16, 2022 at 6:19 PM Rick Macklem wrote: > > Hi, > > At a recent IETF NFSv4 testing event, it was noted that > neither ctime nor va_filerev (called TimeMetadata in NFSv4) > were being updated when a Setextattr or Removeextattr > was being done on a file on ZFS. (Looking at the ZFS code, > this is pretty obviously the case, since ZFS really uses subfiles > and not extended attributes on the file.) > > A Linux wizard says that ctime should be updated, although > there is no POSIX standard. I suspect that FreeBSD's extended > attributes are meant to mimic the Linux ones? No, because ZFS was written for Solaris first. And Solaris's extended attributes are more similar to FreeBSD's than Linux's are. > > So, is this a bug that should be fixed in ZFS or something where > the NFS server does a workaround to make the Setxattr/Rmxattr > NFSv4.2 operations work per the RFC? ZFS, I think. > > rick > ps: It looks like a zfs_tstamp_update_setup() needs to be added > to the ZFS setextattr/removeextattr VOP calls for a ZFS fix, > but I have no idea what the rest of the patch would need to > look like? I think you should open an issue at https://github.com/openzfs/zfs to discuss it. -Alan