[Bug 266236] ZFS NFS : .zfs/snapshot : Stale file handle

Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 07 Oct 2022 13:43:33 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266236

Mark Johnston <markj@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237124|0                           |1
        is obsolete|                            |

--- Comment #18 from Mark Johnston <markj@FreeBSD.org> ---
Created attachment 237140
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=237140&action=edit
proposed patch

It looks like the fid_gen > 1 check is related to the implementation of
zfsctl_snapdir_fid(), which is Linux-specific and sets the generation number to
`!!d_mountpoint(dentry)`.  There is a comment explaining this: "we encode
whether snapdir is already mounted in gen field".

As far as I can see we do not do anything similar when constructing FIDs on
FreeBSD, so the check is wrong there and we should simply drop it.

-- 
You are receiving this mail because:
You are the assignee for the bug.