From nobody Fri Nov 18 01:22:25 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NCzXx4J32z4hlvC for ; Fri, 18 Nov 2022 01:22:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NCzXx398gz3rqW for ; Fri, 18 Nov 2022 01:22:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668734545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+yHR7VJVyYFSrVG4z0FzV/8YtODFz8GgZT+SHDqTMQU=; b=WQ6LXcKnNMBOc5+q2BaZj2Us1ia8JXacsn76LU5qCnyl5L4V4dx2UeStRubu/p/Hwshtk7 VCGnYTGx8i6iCgN0bolSHvM60PCuqLV8Q+xXT8ZOkQ4JtmXWATgrh0lGY/PnvXIwjVJQsF 4hx09OlyofbrJFi28lklcDuY4wIASytDaFPrSKDVJ3bgQqqNK/nk4J2RGwUSsSEU/7zJ6x ot3Ut47vBvNLsFjLbVW5V4XC7N4y2fS2OeJhRmqy8ldWr0zC8NQjPVEpDC7WVHTI2yG6Er Q0QUiaHmuo8OAWe2+e8Aw1BBau4U+zcIV0kTYTnjzPwvWNZdo+bNoRChb1mM+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668734545; a=rsa-sha256; cv=none; b=FRhFYza6bxWb/1dMRzjt0DDoDttHAVG9R76h/0XUGxsf49LUzFz1DybYFvtqOOiayFloUu drvayXbj+3CfhBOEunOxrqKsUQdtvY5bjOvWhXVP/ar1cguvwmvHkStKbXkfS+zl1r79+J 3PalSf5FsIjASB/uVQFJeWlhJji/KZ99aiSefjnFO6uxC+gZPuMBZosIRgGE2xZv/2rhgu rydjrsIn40KO0tAzKGNdRtHVIKVU5+L/eisuuBj1BYoHaYN9eUE9KTuo6UmTQMpEpuahC4 Yuk7NLYRdUs83mo3aDofNZHyGBpTUZbR4+7iBIWDhNy80M/JgMjZAsI3bRlRQg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NCzXx2BxVz13JF for ; Fri, 18 Nov 2022 01:22:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2AI1MPZK090714 for ; Fri, 18 Nov 2022 01:22:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2AI1MP4X090712 for fs@FreeBSD.org; Fri, 18 Nov 2022 01:22:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 263979] [meta] UFS / FFS / GEOM crash (panic) tracking Date: Fri, 18 Nov 2022 01:22:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: crash, needs-qa, tracking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mckusick@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263979 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db999366aab4e2d59cb8869b0e5ef0f70a= b9b9bbe commit b999366aab4e2d59cb8869b0e5ef0f70ab9b9bbe Author: Kirk McKusick AuthorDate: 2022-05-27 19:21:11 +0000 Commit: Kirk McKusick CommitDate: 2022-11-18 01:19:41 +0000 Do comprehensive UFS/FFS superblock integrity checks when reading a superblock. Historically only minimal checks were made of a superblock when it was read in as it was assumed that fsck would have been run to correct any errors before attempting to use the filesystem. Recently several bug reports have been submitted reporting kernel panics that can be triggered by deliberately corrupting filesystem superblocks, see Bug 263979 - [meta] UFS / FFS / GEOM crash (panic) tracking which is tracking the reported corruption bugs. This change upgrades the checks that are performed. These additional checks should prevent panics from a corrupted superblock. Although it appears in only one place, the new code will apply to the kernel modules and (through libufs) user applications that read in superblocks. Reported by: Robert Morris and Neeraj Reviewed by: kib Tested by: Peter Holm PR: 263979 Differential Revision: https://reviews.freebsd.org/D35219 (cherry picked from commit 076002f24d35962f0d21f44bfddd34ee4d7f015d) (cherry picked from commit bc218d89200faa021def77732f3d9fde4f4dee13) (cherry picked from commit 800a53b445e7eb113ba193b1ac98631299178529) (cherry picked from commit 50dc4c7df4156863148e6a9609c03e852e2aeb35) (cherry picked from commit f3f5368dfbef4514686ba2d67f01f314b275227e) (cherry picked from commit 9e1f44d044a58fcd2caaca3f57e69cf6180db3dc) (cherry picked from commit 5bc926af9fd1c47f74356734f731c68145e31c6f) (cherry picked from commit 904347a00c1f9a29f3b17e6e676805036d2494f1) (cherry picked from commit 36e08b0127f97928a2f2c062feed8df9087b2b35) (cherry picked from commit 548045bf57c46cb2f4d43d3d7fa5d8ad37ec7f9a) (cherry picked from commit 3e40d2cc61a00a7d69e99b0fda4040cd1df04c57) (cherry picked from commit 184e3118c1057a97e16230baf0f0433adeeed723) (cherry picked from commit f0be378a66a75ebf335e9388ef0d319a70064d94) (cherry picked from commit 9dee5da7450e8530c9fec51c9a16ecd42da78e55) (cherry picked from commit 82ee4e1c42d70345cbaa1f6dd1874ae98a004910) (cherry picked from commit dcdba3460dd779a0180ec7769ab8cd47c932799e) (cherry picked from commit 017367c1146a69baca6a1a0bea10b0cb02c72d85) (cherry picked from commit 8435a9b20684ba8bcda3df31d06b4d5eac9431a7) sys/ufs/ffs/ffs_subr.c | 303 +++++++++++++++++++++++++++++++++++++++++----= ---- 1 file changed, 257 insertions(+), 46 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=