From nobody Wed Apr 13 21:04:12 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 234061B4C9B8 for ; Wed, 13 Apr 2022 21:04:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kdw7d2r5sz4QxZ for ; Wed, 13 Apr 2022 21:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0F32B135BF for ; Wed, 13 Apr 2022 21:04:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23DL4C3D006753 for ; Wed, 13 Apr 2022 21:04:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23DL4CdT006752 for fs@FreeBSD.org; Wed, 13 Apr 2022 21:04:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 256511] UFS assertion failure when shutting down from single-user mode Date: Wed, 13 Apr 2022 21:04:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649883853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Vl32rWgfdNUX9awlNLNd6qGJYOIXDnrO6+Z4hYV2fM=; b=XLIvcV7HwRs5EnVDeIzsWwgAjvaFPfFaNifWkrvTub/zXiXJOd+V7YSlVDsiIdqq0NnFi+ i45UzZc5F5ss2muCyIyTNrUI1Hnrs7PSRbKGyiakzPmRvCdWtIk3YpEFkXMzpIVqme3uoI hPSPK9t+Rjvfdrx3B8wu2od1PNeaVb/Psmz9TBzCXI27I72BeMBpQwT7e7JUXgMJkaENmI 0x77WV/7ZBh1AlEIpjuBmNzFRgabgs3iElSkCIZSSCgYx/cT7iEaKTw3p4N7kJuSc4Z2Q2 x9Us/HyExllPlWKQTZlv+8CVE3RicEE2vgI2+35HMP9wlYD7c6kShlY9S2j0CQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649883853; a=rsa-sha256; cv=none; b=WeU3/gC/FfCcQCSW3rMeLEBfNVFt7H4QfbI5RkP1yp87jrvG0MAI1CevJveEWhCE7A4dRv I4g3soZ7ws9F1l89aoiah4uliCdtgqb//KUaFqK9jm8YTaJB4FHvWBkTfpe/HEppz112vG gluHYhIhPa+CGY/qKTiPIjRedEdYF9zRFBz7fBlKs2SIhbs4x2Oc9LI70FHUvRY6xRXeeE 3ttJblPVzyJ8GIunF+hgbU1p1/Lk/+/wnY5w4PMRlNrB1AWraQ/WvsXazKpPTSuYG5HHk5 CX9E7euQXQVuFgdb9A/dmPb6KIHCYwB7kgO6xBqg84sT7rYskI9z0cxpo0E9cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256511 --- Comment #8 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd7d8cc9891507ec3d2dcd9334be2afade= 1ed9d0b commit d7d8cc9891507ec3d2dcd9334be2afade1ed9d0b Author: Robert Wing AuthorDate: 2022-03-07 19:18:03 +0000 Commit: Robert Wing CommitDate: 2022-04-13 20:59:12 +0000 ffs_mount(): return early if namei() fails to lookup disk device With soft updates enabled, an INVARIANTS panic is hit in ffs_unmount(). The problem occurs in ffs_mount() when upgrading a mount from ro->rw. During a mount update, the soft update code gets set up but doesn't get cleaned up if namei() fails when looking up the disk device. Avoid this scenario by looking up the disk device first and bail early if the namei() lookup fails. PR: 256511 Reviewed by: mckusick, kib Differential Revision: https://reviews.freebsd.org/D30870 (cherry picked from commit 0455cc7104ec8e8dd54b3f44049112a5a8ca329c) sys/ufs/ffs/ffs_vfsops.c | 148 +++++++++++++++++++++++--------------------= ---- 1 file changed, 72 insertions(+), 76 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=