From nobody Mon May 31 07:09:10 2021 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 28929D7EF25 for ; Mon, 31 May 2021 07:09:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FtmcR0LXwz3pxf for ; Mon, 31 May 2021 07:09:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E23B33C2C for ; Mon, 31 May 2021 07:09:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14V79AvZ058901 for ; Mon, 31 May 2021 07:09:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14V79A95058900 for fs@FreeBSD.org; Mon, 31 May 2021 07:09:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 255473] Infinite writes on UFS with SU+J filesystem Date: Mon, 31 May 2021 07:09:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: xxjack12xx@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255473 --- Comment #37 from Jack --- Created attachment 225399 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225399&action= =3Dedit Unable to disable journal on softupdates after applying patch I'm still unable to turn off journaling with the patch. root@upstairs:/usr/src # git diff diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index 2cc16ab2a2c1..cc3f64b4e70e 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -2653,6 +2653,10 @@ softdep_uninitialize() callout_drain(&softdep_callout); } +static int enable_suj =3D 0; +SYSCTL_INT(_debug_softdep, OID_AUTO, enable_suj, CTLFLAG_RW, + &enable_suj, 0, "Enable the activation of journaled soft updates"); + /* * Called at mount time to notify the dependency code that a * filesystem wishes to use it. @@ -2716,7 +2720,7 @@ softdep_mount(devvp, mp, fs, cred) ACQUIRE_GBLLOCK(&lk); TAILQ_INSERT_TAIL(&softdepmounts, sdp, sd_next); FREE_GBLLOCK(&lk); - if ((fs->fs_flags & FS_SUJ) && + if (enable_suj && (fs->fs_flags & FS_SUJ) && (error =3D journal_mount(mp, fs, cred)) !=3D 0) { printf("Failed to start journal: %d\n", error); softdep_unmount(mp); root@upstairs:/usr/src # uname -a FreeBSD upstairs.jack.com 13.0-STABLE FreeBSD 13.0-STABLE #0 stable/13-n245805-4a4a174959ce-dirty: Sun May 30 23:31:47 PDT 2021=20=20=20= =20 jack@upstairs.jack.com:/usr/obj/usr/src/amd64.amd64/sys/UPSTAIRS amd64 --=20 You are receiving this mail because: You are the assignee for the bug.=