From nobody Sat May 29 23:29:51 2021 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2D601BFE299 for ; Sat, 29 May 2021 23:29:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FsySv0hy7z4n0C for ; Sat, 29 May 2021 23:29:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0042F12FAF for ; Sat, 29 May 2021 23:29:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14TNToim059099 for ; Sat, 29 May 2021 23:29:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14TNTo39059098 for fs@FreeBSD.org; Sat, 29 May 2021 23:29:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238565] panic: vinvalbuf: dirty bufs during unmount if clustered writes return errors Date: Sat, 29 May 2021 23:29:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238565 --- Comment #9 from Konstantin Belousov --- (In reply to Kirk McKusick from comment #8) > I am confused as to why the EIO error is not being returned. Presumably i= n bufobj_invalbuf() we attempt to do the write in the call to BO_SYNC(). If= BO_SYNC() returns EIO, we should return it rather than falling through to = the panic. So how is it that the EIO is not returned? BO_SYNC() does not see any error. Default implementation of BO_SYNC() is bufsync() which is just redirection to VOP_FSYNC(). And default implementation of vop_fsync for filesystems using buffer cache is vn_fsync_buf(), which does bawrite() (non-clustered) or vfs_bio_awrite() (clustered). In either case, the real action occurs in bufdone()->brelse() occuring on write completion. Look at the conditional with the inner comment 'Failed write, redirty.' It does exactly that: if the async write failed, the buffer is redirtied and re-inserted in= to the dirty list. After several loops where the dirty buffer is found/awritten/redirtied, fsy= nc eventually gives up, and vinvalbuf() gets the control back to find the dirty buffer on the list and panic. --=20 You are receiving this mail because: You are the assignee for the bug.=