From nobody Wed Jul 07 22:56:31 2021 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C0F93122A57B for ; Wed, 7 Jul 2021 22:56:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GKvtR4s9Mz3rYx for ; Wed, 7 Jul 2021 22:56:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8A4E715E58 for ; Wed, 7 Jul 2021 22:56:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 167MuVCx003394 for ; Wed, 7 Jul 2021 22:56:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 167MuVBa003393 for fs@FreeBSD.org; Wed, 7 Jul 2021 22:56:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 257043] NFS nfsrpc_readdirplus() panic Date: Wed, 07 Jul 2021 22:56:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rmacklem@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257043 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjg@FreeBSD.org, | |rmacklem@FreeBSD.org Assignee|fs@FreeBSD.org |rmacklem@FreeBSD.org --- Comment #1 from Rick Macklem --- I believe that the KASSERT() at line# 2471 in sys/kern/vfs_cache.c is not feasible for the NFS client. In general, the NFS client cannot know that a directory has been modified locally on the server (or by another NFS client) such that the same file name now refers to a different file. (NFS does not have a cache coherency protocol.) For NFS, what needs to happen for this case is that the new entry needs to replace the old (now bogus/stale) entry. I will look to see if a change in directory attributes can be used to invalidate all entries in the cache for that directory for the case of re-reading the directory, but this will, at best, reduce the likelyhood of having a new file for the same name and not stop it from happening. Not using the "rdirplus" mount option should avoid the problem in the meantime. mjg@, can you change cache_enter_time() so that it replaces the entry instead of panics? I reproduced this by doing the following: - NFS mount and "ll". - go to server and do two "mv"s, where nfs_clstate.c and xxx.c were files in the directory # mv nfs_clstate.c xxxx # mv xxx.c nfs_clstate.c - then "ll" again on the NFS client --=20 You are receiving this mail because: You are the assignee for the bug.=