[Bug 266196] science/octopus: Fails to build with GCC 12: Fatal Error: Sorry, polymorphic arrays not yet supported for firstprivate compilation terminated.

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 16 Nov 2022 16:37:00 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266196

--- Comment #13 from Gerald Pfeifer <gerald@FreeBSD.org> ---
(In reply to Lorenzo Salvadore from comment #8)
> - USE_GCC also supports notations such as USE_GCC=11+ and 
> USE_GCC=11+:BUILD, so I fear something more complex than
> _GCC_VER=${USE_GCC} is needed.

I noticed the same and it got me thinking: Between this report and
PR267215 and there only being two(!) ports left that use the USE_GCC=X+
notation (security/openssl-unsafe and x11-wm/hyprland-devel, and the
former having it disabled), maybe the time has come to end of life it?

Even if we don't, Thierry's patch does not run into any special cases,
so KISS (Keep It Simple Sweatheart) and go with that patch?


(In reply to Lorenzo Salvadore from comment #10)
> I think the variable you need is _USE_GCC. Gerald, since you are 
> still maintaining bsd.gcc.mk, do you confirm we can safely use this
> variable in this context?
(In reply to Thierry Thomas from comment #11)
> Remark: the variables prefixed by "_" are not intended to be exported.

Both of you are right. :-)  Thierry, you are definitely right about
variables whose name starts with a "_". That was my intention here. 

Practically I think we can make this an exception since it's within
the Mk/ infrastructure and document this use in bsd.gcc.mk.

Thierry and Salvadore, if you want to proceed with this patch I'm good
(Reviewed by: gerald) and volunteer adding such a note as follow-up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.