maintainer-feedback requested: [Bug 258488] net/rabbitmq: fix pidfile in rabbitmq rc.d script

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 14 Sep 2021 00:04:05 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-erlang (Nobody)
<erlang@FreeBSD.org> for maintainer-feedback:
Bug 258488: net/rabbitmq: fix pidfile in rabbitmq rc.d script
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258488



--- Description ---
with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256686 update we got
regression related to empty pid file, due to:

https://www.rabbitmq.com/rabbitmq-server.8.html:

-detached
    Start the server process in the background. Note that this will cause the
pid not to be written to the pid file


I suggest going back to running through the daemon(8), patch attached.

PS: Also, we return a zero code on stop/shutdown: it affects some management
systems that expect a positive code.