From nobody Wed Nov 03 15:13:03 2021 X-Original-To: freebsd-emulation@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 45B29184C436; Wed, 3 Nov 2021 15:13:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hkqz0042Xz3rbf; Wed, 3 Nov 2021 15:13:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 1A3FD32r042875 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 3 Nov 2021 17:13:06 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 1A3FD32r042875 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 1A3FD3p2042874; Wed, 3 Nov 2021 17:13:03 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 3 Nov 2021 17:13:03 +0200 From: Konstantin Belousov To: imb@protected-networks.net Cc: Ed Maste , Cy Schubert , Greg V , "freebsd-emulation@freebsd.org" , freebsd-current Subject: Re: current now panics when starting VBox VM Message-ID: References: <36923A7F-23DE-490D-B1FA-A8B064740BD6@unrelenting.technology> <202111022148.1A2LmeHX004930@slippy.cwsent.com> <1ccb6ce3-2cb7-e325-79e3-cda5640f24df@protected-networks.net> List-Id: Development of Emulators of other operating systems List-Archive: https://lists.freebsd.org/archives/freebsd-emulation List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-emulation@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4Hkqz0042Xz3rbf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 03, 2021 at 11:05:11AM -0400, Michael Butler via freebsd-emulation wrote: > On 11/3/21 10:36, Ed Maste wrote: > The kgdb back-trace isn't any more enlightening to me :-( > > __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 > 55 __asm("movq %%gs:%P1,%0" : "=r" (td) : "n" (offsetof(struct > pcpu, > (kgdb) bt > #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 > #1 doadump (textdump=) at > /usr/src/sys/kern/kern_shutdown.c:399 > #2 0xffffffff808cbac5 in kern_reboot (howto=260) at > /usr/src/sys/kern/kern_shutdown.c:487 > #3 0xffffffff808cbedb in vpanic (fmt=, > ap=0xfffffe0129a6a8d0) at /usr/src/sys/kern/kern_shutdown.c:920 > #4 0xffffffff808cbd33 in panic (fmt=) at > /usr/src/sys/kern/kern_shutdown.c:844 > #5 0xffffffff80ca920c in trap_fatal (frame=frame@entry=0xfffffe0129a6aac0, > eva=0) at /usr/src/sys/amd64/amd64/trap.c:946 > #6 0xffffffff80ca95af in trap_pfault (frame=frame@entry=0xfffffe0129a6aac0, > usermode=false, signo=, signo@entry=0x0, ucode= out>, ucode@entry=0x0) > at /usr/src/sys/amd64/include/cpufunc.h:417 > #7 0xffffffff80ca89bc in trap (frame=0xfffffe0129a6aac0) at > /usr/src/sys/amd64/amd64/trap.c:443 > #8 > #9 strlen () at /usr/src/sys/amd64/amd64/support.S:751 > #10 0xffffffff808b4d79 in sysctl_kern_proc_pathname (oidp=, > arg1=0xfffffe0129a6ad8c, arg2=, req=0xfffffe0129a6acc0) at > /usr/src/sys/kern/kern_proc.c:2330 > #11 0xffffffff808dc331 in sysctl_root_handler_locked > (oid=oid@entry=0xffffffff810cf0e0 , > arg1=arg1@entry=0xfffffe0129a6ad8c, arg2=arg2@entry=1, > req=0xfffffe0129a6acc0, tracker=tracker@entry=0xfffffe0129a6ac38) at > /usr/src/sys/kern/kern_sysctl.c:185 > #12 0xffffffff808db88b in sysctl_root (oidp=, > arg1=0xfffffe0129a6ad8c, arg1@entry=0xfffffe0129a6ad80, arg2=1, > arg2@entry=4, req=req@entry=0xfffffe0129a6acc0) > at /usr/src/sys/kern/kern_sysctl.c:2305 > #13 0xffffffff808dbdf3 in userland_sysctl (td=td@entry=0xfffffe012991a000, > name=name@entry=0xfffffe0129a6ad80, namelen=4, old=, > oldlenp=, > inkernel=, inkernel@entry=0, new=0x0, newlen=0, > retval=0xfffffe0129a6ade8, flags=0) at /usr/src/sys/kern/kern_sysctl.c:2462 > #14 0xffffffff808dbc3c in sys___sysctl (td=0xfffffe012991a000, > uap=0xfffffe012991a3f0) at /usr/src/sys/kern/kern_sysctl.c:2335 > #15 0xffffffff80ca9b5c in syscallenter (td=0xfffffe012991a000) at > /usr/src/sys/amd64/amd64/../../kern/subr_syscall.c:189 > #16 amd64_syscall (td=0xfffffe012991a000, traced=0) at > /usr/src/sys/amd64/amd64/trap.c:1191 > #17 > #18 0x000000080315a71a in ?? () > Backtrace stopped: Cannot access memory at address 0x7fffffffc778 > (kgdb) > Try this commit 2d3f95bd1fd4f71769f60b8037c1ff27c75d8258 Author: Konstantin Belousov Date: Wed Nov 3 17:11:33 2021 +0200 proc_get_binpath(): return empty string instead of NULL for strange case where process does not have text. Sponsored by: The FreeBSD Foundation MFC after: 3 days diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index 2156c5c465ba..d11f651960c0 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -2252,7 +2252,7 @@ proc_get_binpath(struct proc *p, char *binname, char **retbuf, vp = p->p_textvp; if (vp == NULL) { PROC_UNLOCK(p); - *retbuf = NULL; + *retbuf = ""; *freebuf = NULL; return (0); }