[Differential] D51188: dtrace: fix symbol address resolving

Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: markj (Mark Johnston) <phabric-noreply_at_FreeBSD.org>
Date: Mon, 07 Jul 2025 18:41:59 UTC

markj added a comment.


  In D51188#1168819 <https://reviews.freebsd.org/D51188#1168819>, @zldrobit_gmail.com wrote:
  
  > @markj I found that we should also delete `st_value = 0` in `dt_module_symsort32/64()`, otherwise `dmp->dm_aslen` would always be lesser than `dmp->dm_asrsv` by at least one. As a result, `dt_module_symsort32/64()` ignore the last element in `dmp->dm_asmap` and  `dt_module_symaddr32/64()` wouldn't find it.  I had to update the patch accordingly. Sorry for interrupting the test suite procedure.
  
  Good catch, thank you.

REPOSITORY
  rG FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D51188/new/

REVISION DETAIL
  https://reviews.freebsd.org/D51188

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zldrobit_gmail.com, #dtrace, gnn, markj
Cc: markj, avg, freebsd-dtrace-list, imp, me_reviews.freebsd_lelf.lu, kpraveen.lkml_gmail.com, bkidney_briankidney.ca, dnelson_1901_yahoo.com, yan.jurak_gmail.com, bcr, lwhsu, jonathan, pstef