[Differential] D51188: dtrace: fix symbol address resolving
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 07 Jul 2025 18:20:18 UTC
zldrobit_gmail.com updated this revision to Diff 158120. zldrobit_gmail.com marked an inline comment as not done. zldrobit_gmail.com added a comment. This revision now requires review to proceed. @markj I found that we should also delete `st_value = 0` in `dt_module_symsort32/64()`, otherwise `dmp->dm_aslen` would always be lesser than `dmp->dm_asrsv` by at least one. As a result, `dt_module_symsort32/64()` ignore the last element in `dmp->dm_asmap` and `dt_module_symaddr32/64()` wouldn't find it. I had to update the patch accordingly. Sorry for interrupting the test suite procedure. REPOSITORY rG FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D51188?vs=158107&id=158120 CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D51188/new/ REVISION DETAIL https://reviews.freebsd.org/D51188 AFFECTED FILES cddl/contrib/opensolaris/lib/libdtrace/common/dt_module.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: zldrobit_gmail.com, #dtrace, gnn, markj Cc: markj, avg, freebsd-dtrace-list, imp, me_reviews.freebsd_lelf.lu, kpraveen.lkml_gmail.com, bkidney_briankidney.ca, dnelson_1901_yahoo.com, yan.jurak_gmail.com, bcr, lwhsu, jonathan, pstef