[Bug 296130] rc.d/zfskeys blocks boot on keylocation=prompt datasets

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296130

--- Comment #12 from Doug Ambrisko <ambrisko@FreeBSD.org> ---
I'd recommend
   : ${zfskeys_prompt_enable:='NO'}

Then if prompts are wanted, they can be enabled.  We should update defaults to
be
diff --git a/libexec/rc/rc.conf b/libexec/rc/rc.conf
index 27e8c8456b6f..6e70baccac98 100644
--- a/libexec/rc/rc.conf
+++ b/libexec/rc/rc.conf
@@ -77,6 +77,7 @@ rc_conf_files="/etc/rc.conf /etc/rc.conf.local"
 # ZFS support
 zfs_enable="NO"                # Set to YES to automatically mount ZFS file
systems
 zfskeys_enable="NO"    # Set YES to autoload ZFS encryption keys
+zfskeys_prompt_enable="NO"     # Set YES to prompt during booting
 zfs_bootonce_activate="NO" # Set YES to make successful bootonce BE permanent
 zpool_reguid=""                # Set to zpools for which the GUID should be
replaced
                        # upon first boot.

I didn't want to get to wordy.  I'm not keen on the timeout for me since if I'm
not there/busy during boot then it will error into single user.  I'm not sure
if Ubuntu times out during unlock via keyboard.  I have a 2nd laptop to test
things before installing it on my main system.

BTW, in -current a while back I had to add locally:
@@ -12,7 +12,6 @@
 desc="Import ZPOOLs"
 rcvar="zfs_enable"
 start_cmd="zpool_start"
-start_postcmd="zpool_poststart"
 required_modules="zfs"

 zpool_start()
@@ -33,13 +32,6 @@
        done
 }

-zpool_poststart()
-{
-       if checkyesno zfskeys_enable; then
-               /etc/rc.d/zfskeys start
-       fi
-}
-
 load_rc_config $name

 # doesn't make sense to run in a svcj
Otherwise it would fail to mount my file systems and drop into single user mode
until I manually ran /etc/rc.d/zfskeys to unlock it.

-- 
You are receiving this mail because:
You are the assignee for the bug.