[Bug 259385] Committers Guide: "Approved by" description missed the case where committer != maintainer
Date: Tue, 20 Jun 2023 18:26:55 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259385
Ed Maste <emaste@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |emaste@freebsd.org
--- Comment #1 from Ed Maste <emaste@freebsd.org> ---
Like this?
diff --git a/documentation/content/en/articles/committers-guide/_index.adoc
b/documentation/content/en/articles/committers-guide/_index.adoc
index 612db2afb0..898fa7e307 100644
--- a/documentation/content/en/articles/committers-guide/_index.adoc
+++ b/documentation/content/en/articles/committers-guide/_index.adoc
@@ -2515,6 +2515,7 @@ There are several cases where approval is customary:
* commits to an area of the tree covered by the LOCKS file (src)
* during a release cycle
* committing to a repo where you do not hold a commit bit (e.g. src committer
committing to docs)
+* committing to a port maintained by someone else
While under mentorship, get mentor approval before the commit. Enter the
mentor's username in this field, and note that they are a mentor:
--
You are receiving this mail because:
You are the assignee for the bug.