Date: Thu, 09 Jun 2022 01:52:32 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264562 --- Comment #2 from Graham Perrin <email@example.com> --- <https://docs.freebsd.org/en/articles/committers-guide/#commit-steps> for new committers there's a ten-step Procedure 1 – however as far as I can tell, there's no second procedure (2) anywhere in the article. For me, as a new committer with a bit for doc, step 5 of 10 should be: src/share/misc/committers-doc.dot – with mentor approval before the commit. ---- Pause for thought. Re: comment 0, here's the single-paragraph section of the page in its entirety: > After the new committer confirms that the account works, the mentor > adds the new committer to the correct access file, using an appropriate > commit message. The commit message should at least contain the committer’s > full name and username, the mentor’s name and what area the new committer > will start to work in. An entry should also be added to the mentors file > in the respective Git repository to indicate the mentor relationship. > Having done all that, the new committer and mentor jointly go through the > first commit operations. The final sentence is for joint actions, _first_ commit operations. For the preceding sentence, it's implicit that addition "to indicate the mentor relationship" is performed by a mentor alone – _not_ a joint action. ---- However, _joint_ step 5 of 10 is an addition to indicate the mentor relationship. Two examples: <https://github.com/freebsd/freebsd-src/commit/b46595affce8c1905c4cd43f1e9853bbb9a4a05f> <https://github.com/freebsd/freebsd-src/commit/bffc3fb3c09b36fd8740242f184d1e8bd8530920> If it's true that the new account creation procedure contradicts the Committer's Guide, then I'm inclined to: 1. treat the setup section of Committer's Guide as definitive 2. make <https://www.freebsd.org/internal/new-account/> consistent, and a little clearer. -- You are receiving this mail because: You are the assignee for the bug.