[Bug 277114] x11/lightdm: fix tty counting in patch-src_x-server.c

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277114

            Bug ID: 277114
           Summary: x11/lightdm: fix tty counting in patch-src_x-server.c
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: desktop@FreeBSD.org
          Reporter: dan.kotowski@a9development.com
          Assignee: desktop@FreeBSD.org
             Flags: maintainer-feedback?(desktop@FreeBSD.org)

In patch-src_x-server.c we currently pass "ttyv%d", but we count TTYs in hex,
not decimal and so it should be:

+        tty_text = g_strdup_printf ("/dev/ttyv%x", vt - 1);

This bug was identified in 221452, but the accepted patches bandage over the
issue rather than fixing the root cause, which is the counting.

This patch was suggested and actually resolves the bug:
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=236106&action=diff

However, it is also possible that these are base32 numbers rather than base16
and points here: https://github.com/swaywm/wlroots/pull/1945

With this fixed, it may again be possible to pull back in val's consolekit2
patch as well:
https://github.com/valpackett/ConsoleKit2/commit/18a058576d118dec428d81c7e2e3369d9ec939d0.patch

-- 
You are receiving this mail because:
You are the assignee for the bug.