maintainer-feedback requested: [Bug 274532] net-p2p/*arr: Switch back to converters/libiconv dependency

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 17 Oct 2023 08:42:41 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-desktop (Team)
<desktop@FreeBSD.org> for maintainer-feedback:
Bug 274532: net-p2p/*arr: Switch back to converters/libiconv dependency
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274532



--- Description ---
In PR 274169 all *arr ports were switched to use 'USES+=libiconv' instead of a
hard dependency on the 'converters/libiconv' port.
Turns out, this is incorrect.

Specifically 'libMonoPosixHelper' (part of .NET) is compiled against the port,
and will break when the port is not installed (incompatible with the base
version of libiconv)

This patch moves all *arr ports back to RUN_DEPENDS on converters/libiconv

poudriere ok
Installed all updates on my setup (13.2 amd64) in production, and runs perfect.

Affects the following ports
net-p2p/lidarr
net-p2p/prowlarr
net-p2p/radarr
net-p2p/readarr
net-p2p/sonarr-devel

Since I'm the maintainer of all, and the update is the same for all, I added
them all in one patch, Same as the patch it undoes.

Thanks to the servarr team for telling me about the error and explaining why
the ports need the libiconv port instead of using the system iconv.
patch by me.