[Bug 266532] x11/lightdm: Login sessions do not respect login.conf

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 22 Dec 2023 16:07:01 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266532

--- Comment #12 from Guido Falsi <madpilot@FreeBSD.org> ---
(In reply to Daniel O'Connor from comment #5)

Hi,

I admit I forgot about this.

I see you filed a p[atch upstream, but dumping a diff file in a github gist is
problematic, nobody is going to really look at it and makes reviewing changes a
pain.

You should really file this as a Pull Request with the upstream code to get
someone to look at it.

Also, the lightdm project is under the canonical umbrella and they have strict
requirements for contributors. You have to sign documents. Unless you do that,
they will not look at your patches, I guess.

Anyway, I could take a look and evaluate including that in the port but I also
need clarifications. Reviewing in a gist is complicated.

Not sure what could be the best way to do this, maybe if I cloned lightdm
github repo you could file your patch as a pull request with my fork so we can
perform the review there?

Because I see a lot of changes, some I don't understand and I really need to
understand them thoroughly before including.

-- 
You are receiving this mail because:
You are the assignee for the bug.