From nobody Sat Oct 08 09:06:10 2022 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mkzmy4RYMz4dwmJ for ; Sat, 8 Oct 2022 09:06:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mkzmy30bNz3Ph8 for ; Sat, 8 Oct 2022 09:06:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Mkzmy1ygcztZJ for ; Sat, 8 Oct 2022 09:06:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29896ATQ078535 for ; Sat, 8 Oct 2022 09:06:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29896Acw078534 for desktop@FreeBSD.org; Sat, 8 Oct 2022 09:06:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 266899] x11/lightdm: update to 1.32.0 breaks autologin Date: Sat, 08 Oct 2022 09:06:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: madpilot@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ merge-quarterly+ X-Bugzilla-Changed-Fields: cc assigned_to bug_status flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665219970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iI57/IEOGUxfRCIpPl4jr+kZ31wHyXRwxvkGzstoi30=; b=J1VIOCWeLhngc2tysttPV2RtnIcIvlQZlWJgWiwtuW60wsq2Net7xGZH3qZ4f9QjE9FNBD mm1ZEudEyK6v5qjX60xDnKtPT6smF5o7LN97BGakKWamTRMNzMd8tmFLB5EUBxUEiINnaC 3El6IR5XeNiAm1835dhDSI1GBtd+6uReDrdUJbzyOxqOovYkl5J/yKz6/CU4x7nIUUGgG8 lKZ0Hh9J9IGLohQPYIh26rXn9R7gWn4frE52S6ZqsGEcXkBozdmJISmloDc5X//JwG2Zze 4b+yY1PNewWGBkZA4LIp6ctG0bNZfDz/cX0O4QQum+Y5ppHxRR5vXTIlAUKplg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665219970; a=rsa-sha256; cv=none; b=ln9jK/Zbnl9rxFbOifKEprALjXqcXDklVXH8lwkWMRjYDVlxRX8Ad836le8MQGNh0twIHL BCnQjxRjJ4YB4LLTNDH8xCNQwBg3JhS1vwZ9gES7zO3uf5pGCtx7RgqoBHCplAKwRzOVca TT/tJl618qUVfyLVW2HIXO79HR4U4t5nCURlTvOcB3K368OEwWS10Xw+Y5Uogh6yTg1JQq v7bq8czagile0fu8/bnlfYur70bMt2qOUxGVfe6HzIMopCjOJ+QUNPu4hi1wuF9yeQ0d8K bwGd0+1PV8AO0sCPJyOW03+XsjvjMDnz5I6h5/BhXkD62cQ0/64GfKiZmRm9pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266899 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madpilot@FreeBSD.org Assignee|desktop@FreeBSD.org |madpilot@FreeBSD.org Status|New |In Progress Flags|maintainer-feedback?(deskto |maintainer-feedback+, |p@FreeBSD.org) |merge-quarterly+ --- Comment #1 from Guido Falsi --- Hi! Thanks for reporting this here, and good catch. For a little context, yes, FreeBSD does not have pam_succeed_if as you have discovered. The offending line was added upstream here: https://github.com/canonical/lightdm/commit/0c21d986ff3c9ec1568b681c746e30b= 6fd25d5cb The port was already patching the lightdm-autologin file, but the patch was= not addr4essing this new line added at the top of it. This addition also did not cause the patching to fail (which could have made the offending change more easily noticeable). Removing the line looks like the easiest solution and also mostly correct. The pam_succeed_if functionality could be emulated using pam_exec(8), but it looks overkill, IMHO. I'm going to test a little before committing. This is eligible to be merged to quarterly too. --=20 You are receiving this mail because: You are the assignee for the bug.=