[Bug 266899] x11/lightdm: update to 1.32.0 breaks autologin

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266899

Guido Falsi <madpilot@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madpilot@FreeBSD.org
           Assignee|desktop@FreeBSD.org         |madpilot@FreeBSD.org
             Status|New                         |In Progress
              Flags|maintainer-feedback?(deskto |maintainer-feedback+,
                   |p@FreeBSD.org)              |merge-quarterly+

--- Comment #1 from Guido Falsi <madpilot@FreeBSD.org> ---
Hi!

Thanks for reporting this here, and good catch.

For a little context, yes, FreeBSD does not have pam_succeed_if as you have
discovered.

The offending line was added upstream here:

https://github.com/canonical/lightdm/commit/0c21d986ff3c9ec1568b681c746e30b6fd25d5cb

The port was already patching the lightdm-autologin file, but the patch was not
addr4essing this new line added at the top of it. This addition also did not
cause the patching to fail (which could have made the offending change more
easily noticeable).

Removing the line looks like the easiest solution and also mostly correct.

The pam_succeed_if functionality could be emulated using pam_exec(8), but it
looks overkill, IMHO.

I'm going to test a little before committing.

This is eligible to be merged to quarterly too.

-- 
You are receiving this mail because:
You are the assignee for the bug.