From nobody Fri May 28 03:26:47 2021 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 29EDABFDF69; Fri, 28 May 2021 03:26:55 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FrqqK6LTKz3lmL; Fri, 28 May 2021 03:26:53 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x52d.google.com with SMTP id m124so1478965pgm.13; Thu, 27 May 2021 20:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=jcqcjk4v7EwP4ZV8aCx1PZT1OMb09Tn7nF/8IW/5LXc=; b=KNY0TYFeDZTa+cJulM6WBOqt/t7UknAL64TAVYOszuKZ43Wo8R7rXqfkRP8Z3+5zIE HwF23vEkvnzBzgsTyWyzpCY4q044rvXDGI2lgdY/OfSQjXiEmZZv40/aQHyV35NNu92Z 9GJgyFjh3iY4aVuphKuIbGCPhCEUoDqY45q5CU+GtamyQwZtZIgnlpbaFQ9+tM+eWzhF alt70ZJPp2POJ+DVSuQYzOJFq+qnGL85CjPrCwt7vRgDxYwUdrdyfofz06vdBnrj17/F XPyT/KP3ktddTjZLTnmWjGRyBCpze/m0YPa0Pza4bLLe338d+uzkOm3YO+Za3Ow6bNSB 6blg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=jcqcjk4v7EwP4ZV8aCx1PZT1OMb09Tn7nF/8IW/5LXc=; b=crVrfc1CSAO1xpnQsFOrrBJQiFnCw/dPJYuI8RSGc0NButRN+LprJjKSGHQKSQ+n6g NFxPX3ZuTzrLYkW3o9DiPR1wv2HOMmouzsqP8d7seUaoge/yKrnB8BwN81lTvK/6Y28A JoQEpGIiAos9wzw6fXwC1giV4GJdoOHZK9okP8gaP9iprkGozZIjgqBxe7GtDV/994Lo v1GgcnTuTzxop3JI+XIjgWx4MrtitDM6zW5KUiiU5/13u3lBbUN5d9KoIhDWedKwWyCY r6UC6RD5SDZGIfBegt+CPMw+15UqzY4Stp3gyHQ9gBTmqgKWQVTOiTWUUu/D1tCene0l wHfw== X-Gm-Message-State: AOAM53101lPiM4AkgSEAXFYtshIaxH9/m4hjJyndmxFaa/oVxYH4J0wf xWFPXx7FSLSl1Mw412XAvw0hv6rttyeN0A== X-Google-Smtp-Source: ABdhPJyHsJcXBwPMq2GHtTIQuwTrUFKIMWu3LwdIG6iviUyaqu7sFrqldXf0ZmEGjrAVvmv+fTc2ZQ== X-Received: by 2002:aa7:9f5c:0:b029:2de:a5f0:d73b with SMTP id h28-20020aa79f5c0000b02902dea5f0d73bmr1642832pfr.41.1622172411981; Thu, 27 May 2021 20:26:51 -0700 (PDT) Received: from ?IPV6:2403:5800:7500:3601:edc1:5fd6:5a0a:6c7d? (2403-5800-7500-3601-edc1-5fd6-5a0a-6c7d.ip6.aussiebb.net. [2403:5800:7500:3601:edc1:5fd6:5a0a:6c7d]) by smtp.gmail.com with UTF8SMTPSA id d22sm3107816pfn.147.2021.05.27.20.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 20:26:51 -0700 (PDT) Message-ID: <94b58596-8721-ddef-3137-bbedd762bd17@FreeBSD.org> Date: Fri, 28 May 2021 13:26:47 +1000 List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: An apology about my commits Content-Language: en-US From: Kubilay Kocak To: Neel Chauhan , ports-committers@FreeBSD.org, freebsd-ports@freebsd.org Cc: portmgr@freebsd.org, gnome@freebsd.org, desktop@freebsd.org References: <600673282f5cd5864a67655c4e156f26@freebsd.org> <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org> In-Reply-To: <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FrqqK6LTKz3lmL X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=KNY0TYFe; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::52d as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-3.20 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::52d:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::52d:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::52d:from]; MAILMAN_DEST(0.00)[freebsd-ports,gnome,desktop] X-ThisMailContainsUnwantedMimeParts: N On 28/05/2021 1:25 pm, Kubilay Kocak wrote: > On 28/05/2021 1:19 pm, Neel Chauhan wrote: >> Hi freebsd-ports@, ports-committers@, >> >> I hope all is well with you. >> >> You may know I have prematurely made Ports commits without review, >> namely 507359c509389602b4060b2c5e203c99911c3578 and >> 0bc7478682b2d7c9393f2dd095d99072070a2f65. >> >> I'm really sorry if I pushed these commits without approval. >> >> I feel extremely guilty for making these commits without approval, and >> almost felt I will lose my commit bit. I even thought at times that I >> will have to switch my PCs/servers to Windows or Linux if all goes >> wrong since I will feel shame for even **using** FreeBSD [1]. >> >> Next time, I will try not to bypass review, especially for big commits >> that touch major packages like devel/glib20. >> >> However, to unbreak the fetching for GNOME Ports that have been >> updated to 40.x, we will need to make one change to Mk/bsd.sites.mk. >> This patch is in https://reviews.freebsd.org/D30514 . This may need >> portmgr approval, but I won't commit it without approval. >> >> Happy hacking! >> >> -Neel Chauhan (nc@) >> >> Footnotes: >> >> [1] - For reference, I work at Microsoft and use Windows at work, but >> used FreeBSD almost exclusively at home since 2012, back when I was >> only 15 (I'm 24 now), and more-or-less the only server OS I have run >> my home servers on since I set that up in 2013. > > It's your thoughts and care that count Neel, don't feel guilty. > > The responses you received could have been a bit more 'matter of fact'. > > What was *actually* important about the replies was 'we should be QA'ing > everything and getting more than one persons eyes on things'. > > > Note (for everyone), some of the biggest impacts are caused by the > smallest commits. > > The idea of a 'trivial update' needs to be related to the dustbin, and > we're still hearing it often. ugh, relegated*