Re: LINT-NOINET failure in gre; warnings in tcp and pf

From: Michael Tuexen <tuexen_at_FreeBSD.org>
Date: Wed, 04 Mar 2026 14:22:09 UTC
> On 24. Feb 2026, at 23:04, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote:
> 
> Hi,
> 
> a universe build from this afternoon UTC has a broken LINT-NOINET:
> 
>     24 /sys/net/if_gre.c:1045:22: error: field has incomplete type 'struct in_aliasreq'
>     25  1045 |                 struct in_aliasreq in;
>     26       |                                    ^
>     27 /sys/net/if_gre.c:1045:10: note: forward declaration of 'struct in_aliasreq'
>     28  1045 |                 struct in_aliasreq in;
>     29       |                        ^
>     30 /sys/net/if_gre.c:1062:4: error: expected identifier or '('
>     31  1062 |         } else if (src->sa_family == AF_INET6) {
>     32       |           ^
>     33 /sys/net/if_gre.c:1069:4: error: expected identifier or '('
>     34  1069 |         } else
>     35       |           ^
>     36 /sys/net/if_gre.c:1072:2: error: expected identifier or '('
>     37  1072 |         if (error == EADDRNOTAVAIL)
>     38       |         ^
>     39 /sys/net/if_gre.c:1074:2: error: expected identifier or '('
>     40  1074 |         if (error == EEXIST)
>     41       |         ^
>     42 /sys/net/if_gre.c:1076:2: error: expected identifier or '('
>     43  1076 |         if (error == EAFNOSUPPORT)
>     44       |         ^
>     45 /sys/net/if_gre.c:1079:2: error: expected identifier or '('
>     46  1079 |         return (error);
>     47       |         ^
>     48 /sys/net/if_gre.c:1080:1: error: extraneous closing brace ('}')
>     49  1080 | }
>     50       | ^
>     51 8 errors generated.
>     52 --- if_gre.o ---
>     53 *** [if_gre.o] Error code 1
> 
> 
> 
> In addition the following warnings:
> 
>     55 make[5]: stopped making "all" in /obj/amd64.amd64/sys/LINT-NOINET
>     56 /sys/netinet/tcp_subr.c:344:27: warning: unused function 'tcp_ctlinput' [-Wunused-function]
>     57   344 | static ipproto_ctlinput_t       tcp_ctlinput;
>     58       |                                 ^~~~~~~~~~~~
>     59 /sys/netinet/tcp_subr.c:345:24: warning: unused function 'tcp_ctlinput_viaudp' [-Wunused-function]
>     60   345 | static udp_tun_icmp_t           tcp_ctlinput_viaudp;
>     61       |                                 ^~~~~~~~~~~~~~~~~~~
>     62 2 warnings generated.
Fixed in https://cgit.FreeBSD.org/src/commit/?id=3d69387ece535fc33821d089aab241bfb9551d69 <https://cgit.freebsd.org/src/commit/?id=3d69387ece535fc33821d089aab241bfb9551d69>

Thanks for reporting!

Best regards
Michael
> 
> 
>     97 make[6]: stopped making "all" in /sys/modules
>     98 /sys/netpfil/pf/pf.c:10791:1: warning: unused function 'pf_walk_header' [-Wunused-function]
>     99  10791 | pf_walk_header(struct pf_pdesc *pd, struct ip *h, u_short *reason)
>    100        | ^~~~~~~~~~~~~~
>    101 /sys/netpfil/pf/pf.c:4836:1: warning: unused function 'pf_icmp_to_bandlim' [-Wunused-function]
>    102  4836 | pf_icmp_to_bandlim(uint8_t type)
>    103       | ^~~~~~~~~~~~~~~~~~
>    104 2 warnings generated.
>    105 --- modules-all ---
>    106 *** [modules-all] Error code 1
> 
> 
> 
> 
> -- 
> Bjoern A. Zeeb                                                     r15:7
>