[Bug 292568] ACPI S3 broken on CURRENT (system can enter sleep state only once)

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 19 Jan 2026 16:30:31 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292568

--- Comment #11 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=4b534b814aa03b44660ede6d5f1a62cb33c24115

commit 4b534b814aa03b44660ede6d5f1a62cb33c24115
Author:     Aymeric Wibo <obiwac@FreeBSD.org>
AuthorDate: 2026-01-19 13:19:52 +0000
Commit:     Aymeric Wibo <obiwac@FreeBSD.org>
CommitDate: 2026-01-19 16:30:10 +0000

    acpi: Fix not calling AcpiLeaveSleepState() in S3 path

    When resuming from ACPI suspend, the ACPI_SS_SLP_PREP bit in slp_state
    was being checked and subsequently unset when calling resumeclock().
    This bit was also being checked for the AcpiLeaveSleepState() call in
    the non-s2idle path, but having just been unset, it was never actually
    being called.

    Change this so that resumeclock() is always being called (since we never
    goto breakout between suspendclock() and resumeclock() anyway) and
    ACPI_SS_SLP_PREP is purely used for AcpiEnterSleepStatePrep() and
    AcpiLeaveSleepState() in the non-s2idle paths.

    PR:             292568
    Reported by:    Marek Zarychta
    Reviewed by:    olce
    Tested by:      Marek Zarychta
    Approved by:    olce
    Fixes:  7669cbd0f064 (“acpi: Suspend-to-idle support (s2idle)”)
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D54777

 sys/dev/acpica/acpi.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.