Re: December 2025 stabilization week

On Wed, Jan 07, 2026 at 02:39:53PM -0800, Adrian Chadd wrote:
> On Wed, 7 Jan 2026 at 13:44, Mark Johnston <markj@freebsd.org> wrote:
> 
> > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291067
> >
> > Indeed, I propose simply removing the driver from amd64 kernels for now:
> > https://reviews.freebsd.org/D54587
> 
> Did it work before? I'm looking to see whether the change added tpm or
> some way to gather entropy from it.

The change added to tpm to GENERIC and enabled entropy harvesting by
default.  Users have reported that resume from S3 fails whenever tpm is
compiled in the kernel, no matter whether or not harvesting is
configured.

> The bug mentioned s3 suspend/resume doesn't work with tpm disabled?
> What's up with that comment, any ideas?

Yes, see the bugzilla link.  I noticed that we don't disable the
harvester when suspending, so I wrote a patch to do that, see D53835.
Apparently it's not sufficient.  I suspect we have to do more and
reinitialize the tpm firmware when resuming, but I don't have time right
now to look further.