Re: git: d549de769055 - main - libc: Remove readdir_r(3) [This broke building rust 1.88]

From: Toomas Soome <tsoome_at_me.com>
Date: Thu, 11 Sep 2025 15:44:36 UTC

> On 11. Sep 2025, at 18:10, Mark Johnston <markj@FreeBSD.org> wrote:
> 
> On Thu, Sep 11, 2025 at 05:01:16PM +0200, Dag-Erling Smørgrav wrote:
>> Alan Somers <asomers@freebsd.org> writes:
>>> Dag-Erling Smørgrav <des@freebsd.org> writes:
>>>> Tell that to the Rust developers.  They have been repeatedly warned
>>>> against using readdir_r(3) for years, as far back as 2016.
>>> Have they?  Looking at rust's github page, I see discussions about
>>> using readdir_r on Fuchsia and Linux, but nothing about BSD.
>> 
>> If you look at these tickets, there are people pointing out that
>> readdir_r() doesn't work correctly even on platforms where it isn't
>> formally deprecated.  The Rust developers chose to fix the Linux case
>> because it produced a link-time warning and ignored the rest.  That's on
>> them.
>> 
>> They also seem to be providing their own prototype for readdir_r(),
>> which suppresses the deprecation warning they should be getting on
>> FreeBSD 15, and turns the issue from a failure to compile into a failure
>> to link.  That's also on them.
> 
> It doesn't really matter whose responsibility it is.  If rust can't be
> compiled on FreeBSD after a FreeBSD change, then it's up to us to fix
> it.  The purpose of FreeBSD, like any other useful OS, is to run the
> software that people want to run.
> 
> +1 to Alan's request to back out the change for now.


How about putting up pull request for rust to fix it?;)

rgds,
toomas