Re: git: af60084978a4 - main - Add description for WITH_PTHREADS_ASSERTIONS [turning off debug for personal builds of main ( and stable/* )]

Nuno Teixeira <eduardo_at_freebsd.org> wrote on
Date: Fri, 05 Sep 2025 22:27:07 UTC :

> Thanks for the hint, I missed 642cd511028b .
> 
> Think I'm good now:
> 
> /etc/src.conf
> WITH_MALLOC_PRODUCTION=yes
> WITHOUT_LLVM_ASSERTIONS=yes
> WITHOUT_PTHREADS_ASSERTIONS=yes

Another potential one is:

QUOTE
> Is there a reason that ASSERT_DEBUG
> ( in share/mk/bsd.opts.mk ) is left enabled
> ( listed in __DEFAULT_YES_OPTIONS )?
QUOTE

You might want: WITHOUT_ASSERT_DEBUG=

See:

https://lists.freebsd.org/archives/freebsd-stable/2025-September/003110.html

for Colin's comment about why it is unchanged
in official stable/* and releng/*.* builds
(instead staying like in main) and my reply.

What you want to do for ASSERT_DEBUG might depend on
your security context's requirements if you are
willing to use a setting that FreeBSD official builds
never use.


Side note:

I'll note that the usage of all 4 of these ignore the
"yes" text detail and are tested only for being defined
vs. not. "no" would get the same result.


> Cheers!
> 
> 
> Colin Percival <cperciva@freebsd.org> escreveu (sexta, 5/09/2025 à(s)
> 23:07):
> 
> > On 9/5/25 14:57, Nuno Teixeira wrote:
> > > For people that turn off debug on main, should WITH_PTHREADS_ASSERTIONS
> > be
> > > turned off?
> > >
> > > e.g.
> > > /etc/src.conf:
> > > WITH_MALLOC_PRODUCTION=yes
> > > WITHOUT_LLVM_ASSERTIONS=yes
> >
> > According to commit 642cd511028b running WITHOUT_PTHREADS_ASSERTIONS
> > improves
> > mutex performance by 5-18%. So yes if you want maximal performance on HEAD
> > you should probably turn this off.
> >
> > Colin Percival


===
Mark Millard
marklmi at yahoo.com