Re: svnlite code in Makefile.inc1 still needed?

Oh! You have svnlite installed.

Warner

On Sun, Oct 5, 2025 at 2:10 AM Bjoern A. Zeeb <
bzeeb-lists@lists.zabbadoz.net> wrote:

> On Sat, 4 Oct 2025, Warner Losh wrote:
>
> > On Sat, Oct 4, 2025 at 2:37 PM Bjoern A. Zeeb <
> > bzeeb-lists@lists.zabbadoz.net> wrote:
> >
> >> Hi,
> >>
> >> I beleive there might be a $ too much in two lines or the arguemnts are
> >> not properly shell quoted or something?
> >>
> >> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character
> "
> >> " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git"
> >> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character
> "
> >> " in variable name "echo r"
> >>
> >> Makes me wonder if svnliteversion magic is still needed?
> >>
> >
> > No. It's unused. And a bit of a nop these days unless you happen to have
> > svn still installed. I never see this error, though. Which shell are you
> > using?
> >
> > https://reviews.freebsd.org/D52912 removes it.
>
> I don't think the shell (csh) matters;  it's the output I presume:
>
> [/usr/src]% /usr/bin/svnliteversion /usr/src/src.git
> Unversioned directory
>
>
> --
> Bjoern A. Zeeb                                                     r15:7