Re: svnlite code in Makefile.inc1 still needed?

Reply: Bjoern A. Zeeb: "Re: svnlite code in Makefile.inc1 still needed?"
In reply to: Bjoern A. Zeeb: "svnlite code in Makefile.inc1 still needed?"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Warner Losh <imp_at_bsdimp.com>
Date: Sat, 04 Oct 2025 23:16:30 UTC

On Sat, Oct 4, 2025 at 2:37 PM Bjoern A. Zeeb <
bzeeb-lists@lists.zabbadoz.net> wrote:

> Hi,
>
> I beleive there might be a $ too much in two lines or the arguemnts are
> not properly shell quoted or something?
>
> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character "
> " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git"
> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character "
> " in variable name "echo r"
>
> Makes me wonder if svnliteversion magic is still needed?
>

No. It's unused. And a bit of a nop these days unless you happen to have
svn still installed. I never see this error, though. Which shell are you
using?

https://reviews.freebsd.org/D52912 removes it.

Warner