From nobody Mon Feb 24 14:46:21 2025 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z1k812Qtbz5pG2w for ; Mon, 24 Feb 2025 14:46:25 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z1k8014WRz3G4Z; Mon, 24 Feb 2025 14:46:24 +0000 (UTC) (envelope-from ianfreislich@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-e545c1e8a15so5159733276.1; Mon, 24 Feb 2025 06:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740408383; x=1741013183; darn=freebsd.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=RzeMNiNo4o1P4yTS1eVPJKdDslZjKZwlmkBmdlkZVpo=; b=gMcJSaCFZoJTtRvZoJzpcU8IlG6cX6sd+57hJXVniuNdM3F+QdP0sp7aDqxg6HbzE2 wzI8f49Hf8QLMttZdA8GkzD7RxPxMc2MjvyqoO67Cq5ETq28sLHoDbTiEYEcrjZI1EiR jwgZgkJD0nClK7nVCicrhUjXs3iamblb88wSDUahGSyihAnlB0bfc4asUMvhbrGIWzl7 slQRh+Iq+GQiQD1fcH6x9fpSMNZ81bXQ4o/jUrfekMMdSrmVZG7lklGe+Lud+t7W1GOQ A6JkO7cl4qOB6x9s5bvXWaDjv8RMPubeyMXiMQtDzxTVwtnhteViI6Yy4k55yIqhmTR3 aZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740408383; x=1741013183; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RzeMNiNo4o1P4yTS1eVPJKdDslZjKZwlmkBmdlkZVpo=; b=dZzQSneFCiejwWfEJ8UXmQKSJbdYOdJjhMMksM9b+7Omw+4MdvgAFz6x0TFrlC8DCj 91f7Zq2T6EosmDRT0+MX0aOKguK/smiM0PqvnyTnlLOLQKCrqH8WOZWaxfVZmZzax/7Q qhTtHNM6I1i+UOHwqwF2s7FGh11zKDjd7G2t/AAIGxEtJv2Y7ezHh9/4yyX5EQGs8tkE EGBUvQzGn1mKJifPKw/PaysqPUN1B14bs6IgA2A9h1PlYV+D4zklgx4lDOrjYFbNBTrX Gim87JVcMPh6YUwVJ25/qB8VJwnUbF+Xq+eg9BPLqwUcTj8YPT80NSqeOSDue3jfeMqx Vqfw== X-Forwarded-Encrypted: i=1; AJvYcCWX5P52YlXjaInayjUlh8/1nixqGvVhpsaer05C84P9ocHA+EHUr1WDIYwHjkNDT6L01MASLSzp@freebsd.org, AJvYcCWgka3YOJbejazbpuBivi/rzxNMM30riw+CTROQ7OyxgZzwN1jxq/QdpmxVuRcOiWxRQ4y1nqU=@freebsd.org X-Gm-Message-State: AOJu0Yy8r0pOh+IwP5/SOwbtMRyY+gUhrN1Tes5DIorhQ2wT2mvo3BLD BHL8dKSD1yAa6uXF01yT3eiFwMcCqZe7QKgocW/nt0AHxWiFAJeDTBaeQUiF X-Gm-Gg: ASbGncsvqXVlMh6ojm9IDnZPN46h8FpBSrI1pm0ePgFRurIaPxaVRqtZFFkxMMWN7Be mW7/wIM1cv+0F3nRCYP2dx5YRxDXEpXXaN8RSdph9QBoJDCeBbg3lmrMTS0LE7Bh69oGNpeC4Eq PmlH1uC8RP8sqdmbOIX8e9yqGSxUzP6h72OTITOsr4AYgxUOcrNo+SLFna2M69+us/cAvCtaZyM 8tvonb30tk0hLZUq1DHM9FKigaXsNqlMOCcPKoN3z9BWrLGJmoHVb8yFFsofulmtlIMsu6zCxps cWBCAzK/ULNr6VgswFmH2zIr8XmBpelc+wl1I8Vfwq00KC5Dgk81y18mL//HQJMoDSum5z5tLTd qRBsT9Q== X-Google-Smtp-Source: AGHT+IFENQ7l7mmXd91Wi9hJGN8WCC/XqDV7gDs0jaJLwbS/xGH+bIPnWDSo64uVutOsub4XuJvw1A== X-Received: by 2002:a05:6902:3483:b0:e5d:b88a:5532 with SMTP id 3f1490d57ef6-e5e24694600mr8169549276.40.1740408382611; Mon, 24 Feb 2025 06:46:22 -0800 (PST) Received: from [127.0.0.1] (107-128-20-168.lightspeed.tukrga.sbcglobal.net. [107.128.20.168]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e5dadea936dsm6214493276.17.2025.02.24.06.46.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 06:46:22 -0800 (PST) Date: Mon, 24 Feb 2025 09:46:21 -0500 From: Ian FREISLICH To: Zhenlei Huang CC: FreeBSD Current , Gleb Smirnoff , Mark Johnston Subject: =?US-ASCII?Q?Re=3A_buildkernel_failure_in_net/toeplitz=2Ec_=28co?= =?US-ASCII?Q?mmit_3b281d1421a78b588c5fc4182009ce62d8823d95=29?= User-Agent: K-9 Mail for Android In-Reply-To: References: <4858aa49-f102-49fc-90c7-9bd7480306c9@gmail.com> Message-ID: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Z1k8014WRz3G4Z X-Spamd-Bar: ---- On February 24, 2025 2:52:14 AM EST, Zhenlei Huang wr= ote: > > >> On Feb 24, 2025, at 12:42 PM, Ian FREISLICH = wrote: >>=20 >> Hi >>=20 >> Building a kernel today failed with: >>=20 >> -Werror /usr/src/sys/net/toeplitz=2Ec >> In file included from /usr/src/sys/net/toeplitz=2Ec:29: >> In file included from /usr/src/sys/net/rss_config=2Eh:33: >> /usr/src/sys/netinet/in=2Eh:692:23: error: call to undeclared function = 'htonl'; ISO C99 and later do not support implicit function declarations [-= Werror,-Wimplicit-function-declaration] >> 692 | return (in=2Es_addr =3D=3D htonl(INADDR_BROADCAST) || >> | ^ >> In file included from /usr/src/sys/net/toeplitz=2Ec:32: >> In file included from /usr/src/sys/sys/systm=2Eh:98: >> /usr/src/sys/sys/param=2Eh:343:13: error: conflicting types for 'htonl' >> 343 | __uint32_t htonl(__uint32_t); >> | ^ >> /usr/src/sys/netinet/in=2Eh:692:23: note: previous implicit declaration= is here >> 692 | return (in=2Es_addr =3D=3D htonl(INADDR_BROADCAST) || >>=20 >> I think this is a result of changes to netinet/in=2Eh (3b281d1421a78) w= hich added a static inline function using ntohl() which is not defined in k= ernel use=2E >>=20 >> Ian >>=20 > > >May you please have a try with this patch ? > >``` >diff --git a/sys/netinet/in=2Eh b/sys/netinet/in=2Eh >index 0925e3aa7669=2E=2E4dad4e4fed4d 100644 >--- a/sys/netinet/in=2Eh >+++ b/sys/netinet/in=2Eh >@@ -689,8 +689,8 @@ void in_ifdetach(struct ifnet *); > static inline bool > in_broadcast(struct in_addr in) > { >- return (in=2Es_addr =3D=3D htonl(INADDR_BROADCAST) || >- in=2Es_addr =3D=3D htonl(INADDR_ANY)); >+ return (in=2Es_addr =3D=3D INADDR_BROADCAST || >+ in=2Es_addr =3D=3D INADDR_ANY); > } >``` > >The `htonl` is pointless here, as INADDR_BROADCAST is all 1s, and INADDR_= ANY is all 0s=2E > >Best regards, >Zhenlei > That compiles=2E