Re: a few observations with 15-prerelease as of early this week
Date: Sun, 31 Aug 2025 13:33:29 UTC
Herbert: > Yes, it's broken. The problematic part: > > GSSAPI_MIT_VARS_OFF= KRB5CONF=${HEIMDAL_HOME}/bin/krb5-config > > and on main HEIMDAL_HOME is empty. > > Maybe we need an OSVERSION check fpr this line? you can't use OSVERSION to check for this because the user can build 15.0 with Heimdal instead of MIT Kerberos. instead, check for the existence of /usr/libdata/pkgconfig/mit-krb5.pc; for example, from www/squid: .if exists(/usr/libdata/pkgconfig/mit-krb5.pc) GSSAPI_BASE_CONFIGURE_ON+= --with-mit-krb5=${GSSAPIBASEDIR} .else GSSAPI_BASE_CONFIGURE_ON+= --with-heimdal-krb5=${GSSAPIBASEDIR} .endif alternatively, perhaps you can assume that if ${HEIMDAL_HOME} is empty then the base system is using MIT Kerberos, but i don't know where that variable comes from. i wonder if Uses/gssapi.mk should provide some sort of variable to allow ports to check what Kerberos version the base system is using without having knowledge of specific files.