From nobody Sat Aug 16 01:13:32 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c3gwZ691Mz64Zts for ; Sat, 16 Aug 2025 01:13:50 +0000 (UTC) (envelope-from bakul@iitbombay.org) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c3gwZ2wL6z3LHG for ; Sat, 16 Aug 2025 01:13:50 +0000 (UTC) (envelope-from bakul@iitbombay.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-b47174b335bso332971a12.2 for ; Fri, 15 Aug 2025 18:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iitbombay.org; s=google; t=1755306824; x=1755911624; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jUnJVpXKqH+Hs0ThbJK2VJLvImftBkd+KsX3DSOE5tY=; b=QRBAWIVrZYH4J05oQTUlAUxN0QuAvNNyr8uC5z73FMPBh3IAEIC098fJ7/8/RNFbd+ rJO0lldQQa1ImkXKscV76B1RC7TkYd59QO1480NrM4HIgo+ry6zRbZc1RTl/9McYC/Mk BJucZ/a6NQAYdrapKhXTw+OniZlbWjWaW5Akc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755306824; x=1755911624; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jUnJVpXKqH+Hs0ThbJK2VJLvImftBkd+KsX3DSOE5tY=; b=CaEQWGE+QKVmlcF7d8aayWSVxSaTN1kEapSguAMC5SE4L93YkMQlvoHXlb15Vzgg1k KrfS1M+wnCwFJbMg4eSW5Y2wf/Lvv5vxTHPXy077RMSAEUZmUY6OqZ/nOq29gloTyTEO CXib75OFRKK1+YugQTaj/rM+aVv/HbDBnMsKLRAt5SLPrX7l6VkVZuD++b/0p76sPTYH XCTFw5kIcGqev0YIjdsG5k1vmQXAgz2v9sTEEGONgIAHAjQhSo77SF9cxMg54JqLBWs3 mqdTHKXdP3qwXnZxB1Wuz1NGoaSkL3A/cCGcKE0SXMi9BObQif+I0sqYebIt9x+VI3rP 7VPw== X-Forwarded-Encrypted: i=1; AJvYcCWvZV/s6dP4lEhhawWhH7txhvLTAUqZWeTI7Y1LZUeSDlsYT1fRvQNMb3+7KBULIz0bGIH0R6p0ZTpp+AAuMAI=@freebsd.org X-Gm-Message-State: AOJu0Yzg49YVwEKc9tbmCCh1fqmhOl6QvRPT9FIVJgtUXTHKKx0ps/Si OlKUoH7D095iyjnUzATJeIpQN+t812VN/Naoz+LCsZSXTsglmaw45CAP4ggdsgtdDA== X-Gm-Gg: ASbGncvduroDCLZu0Xl61WB6os7I3eRB1+OGfkJ2RCk0hQ8TehWXKCQogEMC9Ym7kmf PhdwO/fL67djNwrf6TDNqdSQbevBkE9UVMKNLZul6Ff0Hc1IbV5cLznTGOsHCcLIgHWTJIMoj7B tpNjWsIdAfE2nfFw6dwKKcrd6mgc9EksVWCNVsuH2fWz3PAyuqoKlFrNb0V3xuhfEfXOi1Hkjcu R2EbYsELjywDb3mMavUdc8zcn8SZZJN7vRyINs+BxRBiT1VwrVY2B/gJVnftX4EGW8MFMQq4T/O G0Kqg2o2DCE/4d63taBzlLbJZOFy7jbepxqs5gIjd4nwQueDP9kNgaXgBlsYVV4VE4ODdf4uR4p Y/AkDrQ01RgpEies5emWNnlSNSljV4z5EKCOuNqPIkO4wH41coUlaVNQaE/4JdUeNMm5mMBGUve +KV/MnGq0zNKmqLudR2AA= X-Google-Smtp-Source: AGHT+IHCXRvSim6gokQHx2cW5+NYf8Gwj3vA3DWgI3AJ1HBmJ0pA56PiFZcbO2pJy3FUuwyw9F4m7Q== X-Received: by 2002:a17:90b:1e12:b0:31e:cdc1:999e with SMTP id 98e67ed59e1d1-32341e96021mr2698564a91.1.1755306824024; Fri, 15 Aug 2025 18:13:44 -0700 (PDT) Received: from smtpclient.apple (107-215-223-229.lightspeed.sntcca.sbcglobal.net. [107.215.223.229]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32343c92b2asm2178476a91.29.2025.08.15.18.13.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Aug 2025 18:13:43 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: zfs related panic From: Bakul Shah In-Reply-To: Date: Fri, 15 Aug 2025 18:13:32 -0700 Cc: Rick Macklem , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <6FB3CDFB-9727-41E3-8B52-008B4F0B5FFD@iitbombay.org> References: <14C5523D-1F66-434F-A4D9-E14DA4BBF1E9@iitbombay.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3826.700.81) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c3gwZ2wL6z3LHG On Aug 15, 2025, at 5:57=E2=80=AFPM, Konstantin Belousov = wrote: >=20 > Below is what I gathered so far. I haven't tried this patch as yet but a previous patch kib@ sent to me fixed the problem. Many thanks! Incidentally the breakpoint I set on zfsctl_root_readdir(struct vop_readdir_args *ap) was never triggered. Wrong thread? >=20 > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c = b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c > index 61d0bb26d1e5..c191b2abf6cc 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ctldir.c > @@ -674,6 +674,7 @@ zfsctl_root_readdir(struct vop_readdir_args *ap) > zfs_uio_t uio; > int *eofp =3D ap->a_eofflag; > off_t dots_offset; > + ssize_t orig_resid; > int error; >=20 > zfs_uio_init(&uio, ap->a_uio); > @@ -688,14 +689,20 @@ zfsctl_root_readdir(struct vop_readdir_args *ap) > * count to return is 0. > */ > if (zfs_uio_offset(&uio) =3D=3D 3 * sizeof (entry)) { > + if (eofp !=3D NULL) > + *eofp =3D 1; > return (0); > } >=20 > + orig_resid =3D zfs_uio_resid(&uio); > error =3D sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, = &uio, > &dots_offset); > if (error !=3D 0) { > - if (error =3D=3D ENAMETOOLONG) /* ran out of destination space */ > + if (error =3D=3D ENAMETOOLONG) { /* ran out of destination space */ > error =3D 0; > + if (orig_resid =3D=3D zfs_uio_resid(&uio) && eofp !=3D NULL) > + *eofp =3D 1; > + } > return (error); > } > if (zfs_uio_offset(&uio) !=3D dots_offset) > @@ -710,8 +717,11 @@ zfsctl_root_readdir(struct vop_readdir_args *ap) > entry.d_reclen =3D sizeof (entry); > error =3D vfs_read_dirent(ap, &entry, zfs_uio_offset(&uio)); > if (error !=3D 0) { > - if (error =3D=3D ENAMETOOLONG) > + if (error =3D=3D ENAMETOOLONG) { > error =3D 0; > + if (orig_resid =3D=3D zfs_uio_resid(&uio) && eofp !=3D NULL) > + *eofp =3D 1; > + } > return (SET_ERROR(error)); > } > if (eofp !=3D NULL) > @@ -1056,17 +1066,22 @@ zfsctl_snapdir_readdir(struct vop_readdir_args = *ap) > zfs_uio_t uio; > int *eofp =3D ap->a_eofflag; > off_t dots_offset; > + ssize_t orig_resid; > int error; >=20 > zfs_uio_init(&uio, ap->a_uio); > + orig_resid =3D zfs_uio_resid(&uio); >=20 > ASSERT3S(vp->v_type, =3D=3D, VDIR); >=20 > error =3D sfs_readdir_common(ZFSCTL_INO_ROOT, ZFSCTL_INO_SNAPDIR, ap, > &uio, &dots_offset); > if (error !=3D 0) { > - if (error =3D=3D ENAMETOOLONG) /* ran out of destination space */ > + if (error =3D=3D ENAMETOOLONG) { /* ran out of destination space */ > error =3D 0; > + if (orig_resid =3D=3D zfs_uio_resid(&uio) && eofp !=3D NULL) > + *eofp =3D 1; > + } > return (error); > } >=20 > @@ -1084,7 +1099,8 @@ zfsctl_snapdir_readdir(struct vop_readdir_args = *ap) > dsl_pool_config_exit(dmu_objset_pool(zfsvfs->z_os), FTAG); > if (error !=3D 0) { > if (error =3D=3D ENOENT) { > - if (eofp !=3D NULL) > + if (orig_resid =3D=3D zfs_uio_resid(&uio) && > + eofp !=3D NULL) > *eofp =3D 1; > error =3D 0; > } > @@ -1099,8 +1115,12 @@ zfsctl_snapdir_readdir(struct vop_readdir_args = *ap) > entry.d_reclen =3D sizeof (entry); > error =3D vfs_read_dirent(ap, &entry, zfs_uio_offset(&uio)); > if (error !=3D 0) { > - if (error =3D=3D ENAMETOOLONG) > + if (error =3D=3D ENAMETOOLONG) { > error =3D 0; > + if (orig_resid =3D=3D zfs_uio_resid(&uio) && > + eofp !=3D NULL) > + *eofp =3D 1; > + } > zfs_exit(zfsvfs, FTAG); > return (SET_ERROR(error)); > } > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c = b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > index 1813c411b013..79e808a3ab3d 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > @@ -1695,6 +1695,7 @@ zfs_readdir(vnode_t *vp, zfs_uio_t *uio, cred_t = *cr, int *eofp, > objset_t *os; > caddr_t outbuf; > size_t bufsize; > + ssize_t orig_resid; > zap_cursor_t zc; > zap_attribute_t *zap; > uint_t bytes_wanted; > @@ -1735,7 +1736,7 @@ zfs_readdir(vnode_t *vp, zfs_uio_t *uio, cred_t = *cr, int *eofp, > /* > * Quit if directory has been removed (posix) > */ > - if ((*eofp =3D zp->z_unlinked) !=3D 0) { > + if ((*eofp =3D (zp->z_unlinked !=3D 0)) !=3D 0) { > zfs_exit(zfsvfs, FTAG); > return (0); > } > @@ -1743,6 +1744,7 @@ zfs_readdir(vnode_t *vp, zfs_uio_t *uio, cred_t = *cr, int *eofp, > error =3D 0; > os =3D zfsvfs->z_os; > offset =3D zfs_uio_offset(uio); > + orig_resid =3D zfs_uio_resid(uio); > prefetch =3D zp->z_zn_prefetch; > zap =3D zap_attribute_long_alloc(); >=20 > @@ -1933,6 +1935,8 @@ zfs_readdir(vnode_t *vp, zfs_uio_t *uio, cred_t = *cr, int *eofp, > *cookies =3D NULL; > *ncookies =3D 0; > } > + if (error =3D=3D 0 && zfs_uio_resid(uio) !=3D orig_resid) > + *eofp =3D 1; > return (error); > } >=20