Re: April 2025 stabilization week

From: Vladimir Kondratyev <wulf_at_FreeBSD.org>
Date: Sat, 26 Apr 2025 16:19:03 UTC 
On 4/24/25 21:46, Gleb Smirnoff wrote:
> On Thu, Apr 24, 2025 at 05:48:46PM +0000, Dave Cottlehuber wrote:
> D> On Thu, 24 Apr 2025, at 17:31, Gleb Smirnoff wrote:
> D> > D> This issue actually came up last month but I had no time to
> D> > investigate
> D> > D> then, details
> D> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286045
> D> >
> D> > Is this regression since last stabweek or from an earlier point?
> D>
> D> Just since March stabweek.
> 
> There were no changes to the driver :(
> 
> Any chance you can make a bisect?
> 

I think it is regression from daa098cc37b9

Test this patch:

diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c
index eeabf817616..d82beb52d58 100644
--- a/sys/dev/iicbus/iichid.c
+++ b/sys/dev/iicbus/iichid.c
@@ -630,7 +630,7 @@ iichid_intr(void *context)
  	error = iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actual);
  	THREAD_NO_SLEEPING();
  	if (error == 0) {
-		if (sc->power_on) {
+		if (sc->power_on && sc->open) {
  			if (actual != 0)
  				sc->intr_handler(sc->intr_ctx, sc->intr_buf,
  				    actual);
-- 
WBR
Vladimir Kondratyev