From nobody Mon Sep 18 22:51:30 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RqKmL4Djkz4tsWr for ; Mon, 18 Sep 2023 22:51:46 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic304-25.consmr.mail.gq1.yahoo.com (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RqKmK4FNDz3N2t for ; Mon, 18 Sep 2023 22:51:45 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=B4Hh0875; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.68.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1695077503; bh=PHVya9MWrot6tl2JwZBhVZLUcU1ZaQPkYVjdvosoqx0=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=B4Hh0875PF++nMunQRt+5oZdnnDT2w+SlI4C0yHZ7TL2hdRIBpAtY2jWumt96aCIJ2jYf0ZVPhsb8AolHUV1ziYw80dDSXdXlFWR8D2idxVyGNWKU4/uNVQsXyhL1252V0gr/Kwk/7q4CuXzWPfLZjYENesebf+PsvewEkqC8bRMZtm1jkdSghBJ7fHLMJf9gyIS9Lc8+RKiHVhpFnuqD/c/mTItPpps8aaasQeXWQMZT0oYcSYLaFHcBHG/jSxMFZAAZ4DMu0dUH05bd8uoPKa1vNyPJcmkbv1wSaFV524EFrnr0OQxnEvoA+k+Ij9nM0B9lk5E1NGgWbKS3DVV8Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1695077503; bh=R5+IksOGlcf25I3cIzXhTQZPSGfMi69bGV2RSev60vM=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=icqLjUCgpF23I9vE0/G3ScTDnhY3VdNva/FuskvncekR57X8iXG0ZYSvyVYFSLDZFe8pg8U2es/MmwGMT/uWeHps73TxosHJgoXxjm5Fcf4IzNcgpDrUDLHqsSroK+F8XiJwoUUWmGU9o5tA8DbXIAE7zbSRFk7RL3fpy+vIgHtSt6khWVBFixn4SE4jjPD1giwjNwnbUGA/i+xE8NMH5QgoAkQI3X9eDAg+TpeGDaPSlgLU7ECrE0wiG7opEgARf3Y4BOc/f5ixAFsmWueSmiAhC6s+SkUP4IvFWASZ6hljlNADyCTzrK2ZbESr9+InbOA9Ro/S9Lngtidr3Bbi5w== X-YMail-OSG: 8g_RK_wVM1l86Nlm2Ws4lci1bKhI2syFTbbSTta56RT4Lni_aP9PKFJi8iHvteB 7jQhrDqBsaDOUQTgiRLZHrhcnfNU2GMZAsSes8MdaC_jYVPxemmSsNqILol1dOavT748Qe9F6qq9 qjRRjuppIjw3LquISe64JVWzDWgFdrTTwr9W5MYpzHSrbC5xdGBefcoycskWxHdy.pN42fFKbpOw k8llPCMUpFIw5112QuvtTp91nLIMV9mP_893BtVQgUnk_VoU74J8ChauOzyIMAhSN2Rq7N0vqLxx UCa4giTAhcHTqZ3gAorbYtuhtnCRZO0SCJLN2sBmwbMcGWYZhs6LdH0YqK71WmSk6C.ABvVq81Sm oVHIXeQJ0zlhpzTSwTIMEw3gAX3iv56ES3JDERez8zjYwJwyd.4FdnWeFLFh5gtw3sHKjP9dOoZW mZZ0NZaiu5sC8owrDoLCvovsqYA9FEyUqS07bB62FSnhyNg8V_PrUTPjuiBihYWwVXtMpp8TLEwY WzCCuvTsjdNIgQIKXvdWXpi83OW4.TVGZQ8cdccPVjn.rxK2_hF8Uh1eFWym6ZQBjt5.qZeWhPiI Z08YyTwK_R4x_RETwg9qjmIJwlyrrz4w5k80838Qy1gZMyBq7ukfKp2s.OjSN0iadOPVS8YxknRU oDu35upC_s6EUDq02IFz1OmIw5m9lk.1DGR5Db.3DHsz8wXAWcYtvr6Ckps8ZfuK9yG1OGJwfSRt 3b31BSHLemyyI5uTX_thEopb0CjDoxLbEklkCKwIRwKn6_Scw9NhyOdnK26d.eP98P.R2KGYCGjP ej411IUrGjVbHbz5AmXZaNvdZWEFnMeodMaufvDo3zy1g_vwWY8P0V7Fug4rw98KlnequVdKJ1lM LdDRbiOXZ4GaEv6FViC1.4SApbpBllxLxLmbfUuXVl_eyqm5LjdwwBaKAW8tEVa8644BzCpYXo6e NOfgS5TxZ3NXYBsFlfXxtJD7jsJqfkTFZTs._s7ps3kf_tcSsHwmLYA.esdNn3PkGGcQHGNbcJW4 iqznka6u7_LY9S7V8mS63AO0SkkWiCE7q_y3CHiD8zAZJ6dQgANYW6TQl5XaOX4.qzLHmepugVKP Nkh3o_3PwVzz35axQQwUCL8JRnVaCsqJif1bng8WcUy2RPgRt8mJSXu7znQmeoWO4srRflPqhpGL _TtXN38R6HWGEwcwjLrM.OC4c.1awILhwyMT4QB0.3MqkL14o5MaeaZTSAu0ad_bL2xI6FoCloeJ BMt6HocucJ4dLUU67H4n0Lekx_LHuNROm2gyHD88v.ZE650ElQy9NONBV2cZAya5xzZm1Enf4oGX W6Cnl0tnp8cKN1q9mvuHfIZFZ6TwksCAhYqiIOsrz.Iunwt7dEnGA4gJsnWupb0_3XDn1Ml386ys bBG8GPFzGu_fP6O6Hi1dtz4cepi7RVWguqyuTjLJsta9nXvkNMmPGYiR8PLqQ9wgGUpKYjnwN2ff zrTLG7aMt1rFxn3nbEW9HvMHM5IgK3HMtEVDj9b6DX.b9UykD7cwUT6XIvvG5oax0IMXMRQyEI.x axC.ZaCdAaV5gwak1njPyVlA8GUGMSpe6MVMW9KHhfnA97Fd0raM2d.sutV_ERYVu0KPverGDVTr wkOeQKgkMI7xdlFL53I3CbczjpM93g1gboOihyNJyyQ6DwjbsWFB3Kabily87JlBkm9eJcMFU7v. vhHKJnHVQ94xEJUqzDnIfgDe7PsiTV75DG3ROA_53vQC4BFtXtklCuY6MvskOnZhFxN.Kh3Mx8LD fdOc6SHu7wCkr60xp5.zM98R.rSN480Krb_21w.tzUwHEMnl7I0yaI.Y6If4vEzqQxFDI47ep9UP a9BEirkyiGiu9W_4wwW1FP9V0Xo6v.lCC4ovqSZjAkfEmpXcEDNIWKoMwqBTETS_fBAlvnMLg7Q4 zfuaOCM89xB4X.9Kb.TbP5bcZxgpBO7MTulfw7FqrFhtLnBYEyBUN8vHswriYt4bQzPUp2unIai5 .N2TNhliFwyU4gPBkwt7NbwD7fJIrUvlhHyniilRWXEt6P1NVQskHSqdphCuVJM0ljRg.BZzR..Z zlQFhfNujGAoL_W1G0Z3Pt0Zhzdy_4Prd7iJgViyoXub0smFCTwUHHg8jeW.VrWzMUvylLFeYRGL eEwDAT_1e51FLuCrWj8S.PyaD3yCZhgQ_84.o0qaZ50vHNmeybmfFvKHu07zAz_Um7QwAoEuxzap SLREzNG31.wk8owYVySxfSWRXzQAT.qaLGBBueJ3m1N3OCsDz71QoQwFO9D9jFxvZMD3q X-Sonic-MF: X-Sonic-ID: cc781901-4d23-4d40-adb3-75a545bb8b29 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Mon, 18 Sep 2023 22:51:43 +0000 Received: by hermes--production-gq1-77657878bb-d5lfb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 51854f570d27b141270c79a0dcdf8cd1; Mon, 18 Sep 2023 22:51:40 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: vfs.zfs.bclone_enabled (was: FreeBSD 14.0-BETA2 Now Available) Message-Id: <5C769ACC-F264-4BAB-AF7B-8C463A4BD99E@yahoo.com> Date: Mon, 18 Sep 2023 15:51:30 -0700 To: Alexander Motin , Current FreeBSD X-Mailer: Apple Mail (2.3731.700.6) References: <5C769ACC-F264-4BAB-AF7B-8C463A4BD99E.ref@yahoo.com> X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.206:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.68.206:from]; DKIM_TRACE(0.00)[yahoo.com:+]; TO_DN_ALL(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4RqKmK4FNDz3N2t Alexander Motin wrote on Date: Mon, 18 Sep 2023 13:26:56 UTC : > block_cloning feature is marked as READONLY_COMPAT. It should not=20 > require any special handling from the boot code. =46rom stand/libsa/zfs/zfsimpl.c but adding a comment about the read-only compatibility status of each entry: /* * List of ZFS features supported for read */ static const char *features_e: vfs.zfs.bclone_enabled "com.datto:bookmark_v2", // READ-ONLY COMPATIBLE = no "com.datto:encryption", // READ-ONLY COMPATIBLE = no "com.datto:resilver_defer", // READ-ONLY COMPATIBLE = yes "com.delphix:bookmark_written", // READ-ONLY COMPATIBLE = no "com.delphix:device_removal", // READ-ONLY COMPATIBLE = no "com.delphix:embedded_data", // READ-ONLY COMPATIBLE = no "com.delphix:extensible_dataset", // READ-ONLY COMPATIBLE = no "com.delphix:head_errlog", // READ-ONLY COMPATIBLE = no "com.delphix:hole_birth", // READ-ONLY COMPATIBLE = no "com.delphix:obsolete_counts", // READ-ONLY COMPATIBLE = yes "com.delphix:spacemap_histogram", // READ-ONLY COMPATIBLE = yes "com.delphix:spacemap_v2", // READ-ONLY COMPATIBLE = yes "com.delphix:zpool_checkpoint", // READ-ONLY COMPATIBLE = yes "com.intel:allocation_classes", // READ-ONLY COMPATIBLE = yes "com.joyent:multi_vdev_crash_dump", // READ-ONLY COMPATIBLE = no "com.klarasystems:vdev_zaps_v2", // READ-ONLY COMPATIBLE = no "org.freebsd:zstd_compress", // READ-ONLY COMPATIBLE = no "org.illumos:lz4_compress", // READ-ONLY COMPATIBLE = no "org.illumos:sha512", // READ-ONLY COMPATIBLE = no "org.illumos:skein", // READ-ONLY COMPATIBLE = no "org.open-zfs:large_blocks", // READ-ONLY COMPATIBLE = no "org.openzfs:blake3", // READ-ONLY COMPATIBLE = no "org.zfsonlinux:allocation_classes", // READ-ONLY COMPATIBLE = yes "org.zfsonlinux:large_dnode", // READ-ONLY COMPATIBLE = no NULL }; So it appears that the design is that both "no" and "yes" ones that are known to be supported are listed and anything else is supposed to lead to rejection until explicitly added as known-compatibile. This matches up with stand/libsa/zfs/zfsimpl.c 's: static int nvlist_check_features_for_read(nvlist_t *nvl) { nvlist_t *features =3D NULL; nvs_data_t *data; nvp_header_t *nvp; nv_string_t *nvp_name; int rc; =20 rc =3D nvlist_find(nvl, ZPOOL_CONFIG_FEATURES_FOR_READ, DATA_TYPE_NVLIST, NULL, &features, NULL); switch (rc) { case 0: break; /* Continue with checks */ =20 case ENOENT: return (0); /* All features are disabled */ =20 default: return (rc); /* Error while reading nvlist */ } =20 data =3D (nvs_data_t *)features->nv_data; nvp =3D &data->nvl_pair; /* first pair in nvlist */ =20 while (nvp->encoded_size !=3D 0 && nvp->decoded_size !=3D 0) { int i, found; =20 nvp_name =3D (nv_string_t *)((uintptr_t)nvp + = sizeof(*nvp)); found =3D 0; for (i =3D 0; features_for_read[i] !=3D NULL; i++) { if (memcmp(nvp_name->nv_data, = features_for_read[i], nvp_name->nv_size) =3D=3D 0) { found =3D 1; break; } } if (!found) { printf("ZFS: unsupported feature: %.*s\n", nvp_name->nv_size, nvp_name->nv_data); rc =3D EIO; } nvp =3D (nvp_header_t *)((uint8_t *)nvp + = nvp->encoded_size); } nvlist_destroy(features); return (rc); } I do not know if vfs.zfs.bclone_enabled=3D0 leads the loader to see vs. not-see a "com.fudosecurity:block_cloning". =3D=3D=3D Mark Millard marklmi at yahoo.com