From nobody Mon Sep 18 10:49:10 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rq1kg4FJ5z4t0Wh; Mon, 18 Sep 2023 10:49:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rq1kg1yjTz3ZKD; Mon, 18 Sep 2023 10:49:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-31ff985e292so2545311f8f.1; Mon, 18 Sep 2023 03:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695034153; x=1695638953; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=Gmrp47G/YOPEzz8CTt1sBfFO8OyhTt3ZuT52gzlE1qM=; b=D04yMUB7hbblzlKz8NBFC+UT+S4QMtSuJZevnJxFxq8wsOAgA2Btm6nWaM6iFC0c8R 5WmPw7z8eH3rbz+G74QXX3eu1FYy2N6oluR5b3NqEOaE1yRqqYd+4vuXz/Ruhy5Q6y2n TiNPEWcKihvL/wripLvQOlpjH6K36lbbTtKwMwykuUq2UNyRb8B/tS5/4eirIiGsrHaV P4ovATJ7twNYPQb4HuWqpXYN2JaSwjTcHmRG/G9U6DO7o5mt0EhWKC4d8Xy/v2tbJ1WK ovMyMRIwiEpZL6Nn892vRvbOHKdDP9lgL1AGSH9l0exHS80aoqmWD1u+4t+8Ldko25P1 VjnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695034153; x=1695638953; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gmrp47G/YOPEzz8CTt1sBfFO8OyhTt3ZuT52gzlE1qM=; b=IRjnBfH9TWHm2NA10f69BwpURT8n6/Yq/cc4+5sfSYYxmdc5kTYn+vrpp7osyKv5HW io55lHIrfnKI8nclIv3KHS4EjBcffdp6x6kT4YMiuZ0adHna0CrO4S9uNG+oqnG6XiTX 6+VBv8V6/DCGahlWuhBJeFhk/AtWOu148hHBjwKn3XDLsMFS81u7DkFWkv1Yvk1oK4Y6 mkc+jNk5ipT3hdilleznevEsJCEDd+pKUJZQNsBdX0/oMHNNQLXfzvmvdP7x9WoopdDI FkIyJadCPjLnK7345277u3ZKFGQnEgCEJaTINVs9CD20JtLGo6j2Vnx9pWtUxV8eJOtf XTTw== X-Gm-Message-State: AOJu0YwnZyRBt2AssWK9Div2ASN/oHdoaszNuCi+5SU6zkYmk3CCvkkt er+MPI2PkRjZqlkmax8Vwfwk6FIFd1Y= X-Google-Smtp-Source: AGHT+IEKpOC0kdLgM63JtH9HQJ35+epuIykRzieP+uRygKc76zI6Zvfpvnli0nj4qAWUBTeuRp6X2A== X-Received: by 2002:a5d:4706:0:b0:319:7c14:b06b with SMTP id y6-20020a5d4706000000b003197c14b06bmr6745448wrq.47.1695034152723; Mon, 18 Sep 2023 03:49:12 -0700 (PDT) Received: from framework (91.76.114.89.rev.vodafone.pt. [89.114.76.91]) by smtp.gmail.com with ESMTPSA id z15-20020adff1cf000000b003179d5aee67sm12113560wro.94.2023.09.18.03.49.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 03:49:11 -0700 (PDT) Date: Mon, 18 Sep 2023 06:49:10 -0400 From: Mark Johnston To: Martin Matuska Cc: Alexander Motin , Graham Perrin , freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: Re: vfs.zfs.bclone_enabled (was: FreeBSD 14.0-BETA2 Now Available) Message-ID: References: <20230916002831.GU52318@FreeBSD.org> <02c53c2e-127b-33b4-e13d-f6f6589dd5fe@gmail.com> <7a6692de-f096-637d-fe48-d5fb93e54f8b@FreeBSD.org> <8e4e4000-4680-0550-6772-32a6a3101761@FreeBSD.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e4e4000-4680-0550-6772-32a6a3101761@FreeBSD.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4Rq1kg1yjTz3ZKD On Mon, Sep 18, 2023 at 07:31:46AM +0200, Martin Matuska wrote: > I vote for enabling block cloning on main :-) Have you or anyone else run through the test suite with block cloning enabled? > On 16. 9. 2023 19:14, Alexander Motin wrote: > > On 16.09.2023 01:25, Graham Perrin wrote: > > > On 16/09/2023 01:28, Glen Barber wrote: > > > > o A fix for the ZFS block_cloning feature has been implemented. > > > > > > Thanks > > > > > > I see , > > > with > > > in stable/14. > > > > > > As vfs.zfs.bclone_enabled is still 0 (at least, with 15.0-CURRENT > > > n265350-72d97e1dd9cc): should we assume that additional fixes, not > > > necessarily in time for 14.0-RELEASE, will be required before > > > vfs.zfs.bclone_enabled can default to 1? > > > > I am not aware of any block cloning issues now.  All this thread about > > bclone_enabled actually started after I asked why it is still disabled. > > Thanks to Mark Millard for spotting this issue I could fix, but now we > > are back at the point of re-enabling it again.  Since the tunable does > > not even exist anywhere outside of FreeBSD base tree, I'd propose to > > give this code another try here too.  I see no point to have it disabled > > at least in main unless somebody needs time to run some specific tests > > first. > > >