From nobody Sun Sep 10 19:24:30 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RkKYD46P4z4sxXm for ; Sun, 10 Sep 2023 19:24:48 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RkKYD1jc5z3J5j for ; Sun, 10 Sep 2023 19:24:48 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694373886; bh=8ZtjGfqWBMRASXm6aSE+S0U378n2i4vQh+HnhmXTTwQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=sG5t2qX6RQcSkc8Du1Cysu5QhjEPLGG4MQNqFDqvMe/mYCJ2HmkoQE8h6prKpc+aEC0+o2v4PD0td0MPNslLI40xyw9s5eckKT/W2Gky8LO1cnypbXMF+yyp1ZHmoVaE4w5kgPstNzt4+UwofsgBP9/Cb6VNKDr1YtOqOyPkf15v7lw69J/0y/1YHHZzpxOVhdeh8CQjJXJL7p1bvJMxHMJI0//lNVFGUE6Vr4ZdO5+gAUwRaDhVckBa8sfFlV8U8RvFCxhXEOcgcW1P7BmdLS7+eNMk0po4Fg4rl13RKclsk0qnso0qj30Pd96ntnyKCHQoRHVhb+hNq3/Bg0MRyg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694373886; bh=VSYp/koO6t7tSTUEOjfhy/Bd3wFrUiOTndwA1/1cDEE=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=NmS+BgfuxTGfGvPNEM77Azu2M2+xMjxQpwManNAaUg2cRmQzTP3JykogSMVdtVqjLFa7NZboyR7z8gTcf9EMC+DUuew+ebkY16W4D0mm9eBelveluui4aKpqvMo5ovXagauUbZavD+e01cNfJerkmV9mGOpH//qW0JksK2+4jYa3DkTiMIfrPQAtWuIwP9A5UYOef4Svl77wEc79199JAi+ewdEved208InFrAfeOraNcueE3oWthjnlSXMWrUelB/RjxIt0tcBMAqrcFXckpt5wN4riae7shqDbA6lNuW2ndvMPmGjYQ+VVkZrNz/AZGlu4k1AdD5tQL26PZD5xkQ== X-YMail-OSG: xZo.fwsVM1ndf2PLpQ_74JFYYqIs5URzouBTlAiAasE4IivYAhsFsmH82Zatww9 n_xESI6xq3OU4qx_tgud5KgdgS94LH_nBOaB.LT_QFu1CAurI5MLNMUOTWs6B.acz_IiBxkSO8h3 jBtch3D3MBW55Ssw3NHdnPpjilUW0MDz_5LDHpatQgr17SQkeWG9o8An1K5_FUNuG3H7d7wOZDMi L0Sp9ypfUQVJAXcdx5n_MWeGGHFBzFnDlgHzPo7uZIWREcy2WfihiDNTyldJ49Mm6eXcZqg4AE34 Y7Dbku6K3806XHxHgVz0vOyY_rmRHZKFOu7iAgcVg5wPkzIAEyTudnZWFNFsUADVTzIRZ5o70407 Za_DfRThJaR_gckSDuW7wCL8p.vSItA8bhBzWhPAu8Rl7C86ID8c.oBpsCQZVtOJMl8KQpreK8h0 D17yrtGVaq9_evD.LVmmIv.gHT_U4fHkmfLwGyN3s2.nKfNm1RkXsFxQoplusJiaZh0tNg4Ug6f7 r53aHKw1VANeYx3M_Kb9UzkNHIca2h.M2tklOFObEfyse_3UJTy0FJhfBomrOAZc6A8VWFXtHb0. cRWbE7xeMbfETTZwTK8h0pkV6yf_5I6XeKPS17Hr4bDbsPq0k0AlGIGeVcspNA4BeVHQACVS95BA xL01k40eZ80.LQ7mzRL6Bx7n6ZPgs.O88zHLYbvTIWeNN3DsgzIr3XWsG4Ne5Hiv0MkO.Gq62fpG 5ym5tUJbA49d7N2zODBzf14i.vaO1km9K6frCgbjxC4PvK4DxyoWTvjQ_OOjUFOniANquprNyrk_ f4vEeEAifkiNngq4NAZGwetf0OyvJmztvxZxg7NAB31Mq3Alvn39vhWcLHxLRly_iZSJvqvpklc0 ULJ2FSVvz3KznJIYGBw6pqiULdC9oXlBfGOLd4mFU7Sg8mFDUiBLBSxXRmAd4nHCSQN5271ADTA7 cC7iln4Dj0zgEyS1gF4GTnBinNuy.UzUYqrOCS67Jevdb_3wVo2gSxM6.ynF72DT74baSdzNxIms xyoal0UNHP3XU36IUiYPCzfQD5rpc1nxDGLUV.PSFd2jDUW5xHE1HkmHF4uj7AmpYnVV8BPQMTDv R.2kr.j3TkXwLzmJubaPW6_wVANMCLc10fkSmsJt0KwIKamU670h_6e9jGfzXWa1efDpFTBZqgOi qSlNJIdSKz0Rbs9GX5Yx5BddZgyHA8dIg92Rb.rCwkXDpOb3t9X5SMPd8cc.o0yHSlE71KGxGpao E4lINhcVbt1BSX8K1j2l5EBHgD3vgxEFX7K5RsH9dfr.eG5Td4fVGYHX3MA1DXuu.US2QfGxZcRj lOZfCbA5PYAUfhZ2KAWJ0_H8DhnclPATKp2VPY_od.ZSN42l7RSR_AUVb95SnlDCwuRJfZqjh2_e G3U3AztqXrk_jhSt4QujBW6jm0jZVRrlKagXt8PffsOQWr2Vxdh1lhMUPyCdRCo.189ZQOlSuOs9 qYE64k4osej439aBWzW1sfHK9i_kLsYpDK4UOWlnlq8SKgooesyyEMFsmWn2CeIzSHgr2QtRnapI AhWWHXSXjZF7GzgaWF1z48VCQWrZQA0IkzaeGwbDjo8xTzR_NgoAdHv0Ppcn__b64Y0UB60Z7Kb4 vZLNlrjE6qX.y8XEbXspMRV4EY4BMgl_0QRT9Xl9bYOilBEkiY_87VLiAA3PzSOG9DNKDEYTfV8v 6mllmmJLIX1Gsob3W6eMIdELxFv80M6_dB4q2Y9y9hvPgJXw3hlPRahNrhQRaynALbWGhVcnb52E _sShm4YtQ2imUGbZqPIhv3gpWUrufrwG2X7C3UQSlchyTPH5IHTVr45DDF92s99e3xXBMtL8_KDZ 42pe7ps11Rb2_dg7sA32PozXUxypB8Ffsf0rPjcHl9yZt9uyzMvNKQ3swxBjO5o3vtBDmGV0zDfE ThYUcPlXvXCDFdnrQtEVLKPMQjFtgcUCaogSxybh6WcWmZoBhlVYiKWEzZd4ez9NTDxr8QM.IKK4 Zq.C8pcGBgf_O0ZKx32Gl8jYJVvonr4Grra7Kj1.isjT8ESyIcvnzZjINTZcWg1VHWoHnJl74SAD YXO1JX1_dmoa9aanwUHse4dIbUra.gG5Yb6mWxp9lkATQXb2Vtj3wKZzmpJvqf8zYF2Gr.DVivTc mCaxWFsb0y5DK2F5eWe48agwRk66sIGtKiCH.1_dFiAWDS1gRuZXNkE50tLCI4Ca1.ev8b37RgHW KMFmLG4k.sYPuHH3HOcbNQ2.VuCuOm1KmZvO69aYmBvxWDR6pXnL5_QkEMmuMaS0Wbafqk8GifTC h9GB.lw-- X-Sonic-MF: X-Sonic-ID: 36a27254-d021-4b83-86c3-8028e509e54e Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sun, 10 Sep 2023 19:24:46 +0000 Received: by hermes--production-gq1-6b7c87dcf5-rj56s (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fd4f49afe0058c6c4d46fac41f729629; Sun, 10 Sep 2023 19:24:41 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: Looks like the kyua zfs tests likely are not used on aarch64 or other contexts with unsigned char From: Mark Millard In-Reply-To: Date: Sun, 10 Sep 2023 12:24:30 -0700 Cc: Martin Matuska , Alexander Motin , Pawel Jakub Dawidek , Glen Barber , Mike Karels , Current FreeBSD , FreeBSD-STABLE Mailing List , freebsd-arm Content-Transfer-Encoding: quoted-printable Message-Id: References: <96C2F8F3-D3F0-48FC-BEEC-E3C983BD680A@yahoo.com> To: Warner Losh X-Mailer: Apple Mail (2.3731.700.6) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Queue-Id: 4RkKYD1jc5z3J5j On Sep 10, 2023, at 11:21, Warner Losh wrote: > On Sun, Sep 10, 2023, 11:10 AM Mark Millard wrote: >> On Sep 10, 2023, at 00:31, Mark Millard wrote: >>=20 >> > kyua tests that use the: >> >=20 >> > /usr/tests/sys/cddl/zfs/bin/mkfile >> >=20 >> > program like so (for example): >> >=20 >> > mkfile 500M /testpool.1861/bigfile.0 >> >=20 >> > (which should be valid) end up with mkfile >> > instead reporting: >> >=20 >> > Standard error: >> > Usage: mkfile [-nv] [e|p|t|g|m|k|b] ... >> >=20 >> > which prevent the kyua test involved from working. >> >=20 >> > Turns out this is from expecting char to be always >> > signed (so a -1 vs. 255 distinction, here in an >> > aarch64 context): >> >=20 >> > . . . >> > (gdb) list >> > 179 /* Options. */ >> > 180 while ((ch =3D getopt(argc, argv, "nv")) !=3D -1) { >> > 181 switch (ch) { >> > 182 case 'n': >> > 183 nofill =3D 1; >> > 184 break; >> > 185 case 'v': >> > (gdb) print ch >> > $16 =3D 255 '\377' >> > (gdb) print/x -1 >> > $17 =3D 0xffffffff >> > (gdb) print/x ch >> > $18 =3D 0xff >> > . . . >> >=20 >> > With the mix of unsigned and signed it ends up >> > being a 0xffu !=3D 0xffffffffu test, which is >> > always true. >> >=20 >> > So the switch is reached as if a "-" prefix was >> > present (that is not). Then the "option" is classified >> > as invalid and the usage message is produced. >> >=20 >> > Apparently no one had noticed. That, in turn, suggests a >> > lack of inspected testing on aarch64, powerpc64, >> > powerpc64le, armv7, powerpc, and powerpcspe. That, in >> > turn, suggests that kyua test inspection for the likes >> > of aarch64 is not historically a part of the release >> > process for openzfs or for operating systems that include >> > openzfs. >> >=20 >>=20 >> Looks like the mkfile.c traces back to a former port >> sysutils/mkfile that was unfetchable as of 2019. And, >> looking around, it seems the kyua zfs tests may be a >> FreeBSD only thing, not adopted in openzfs. >>=20 >> So various implicit assumptions when I wrote the note >> do not actually hold. >>=20 >> FreeBSD would have to do additional testing via kyua, >> beyond what openzfs does for testing, to discover the >> unsigned char related mis-behavior in the mkfile that >> FreeBSD's kyua tests use. Only FreeBSD variants are >> likely to have a similar status, not general openzfs >> including operating systems. >=20 > I wonder how hard ot would be to look for the char =3D getopt() = pattern with coccinelle >=20 Unsure. But to be sure that the implication that I was also trying to point out is not lost: kyua testing of zfs (and more?) for aarch64 (tier 1) is apparently not being done (or at least the results are not being inspected). Similarly for armv7 and all the powerpc*'s (not tier 1's, however, so not as surprising). Side note: Via other exchanges that have been going on I learned to look in the likes of: https://ci.freebsd.org/job/FreeBSD-main-amd64-testvm/*/consoleText for what to "pkg install" for kyua test runs to use for normal runs (at least the subset compatible with architecture being tested). I'd only figured out a (large) subset previously for aarch64 and armv7. I'm not aware of there being other documentation for what is appropriate for setting up such for kyua runs. =3D=3D=3D Mark Millard marklmi at yahoo.com