From nobody Sat Sep 09 00:27:52 2023
X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RjDN470yNz4t76d;
	Sat,  9 Sep 2023 00:28:04 +0000 (UTC)
	(envelope-from pjd@FreeBSD.org)
Received: from mail.dawidek.net (mail.dawidek.net [94.130.64.56])
	by mx1.freebsd.org (Postfix) with ESMTP id 4RjDN40Pplz3LjS;
	Sat,  9 Sep 2023 00:28:04 +0000 (UTC)
	(envelope-from pjd@FreeBSD.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: from [192.168.250.133] (c-73-70-21-143.hsd1.ca.comcast.net [73.70.21.143])
	by mail.dawidek.net (Postfix) with ESMTPSA id 6EEBD22F73;
	Sat,  9 Sep 2023 02:27:55 +0200 (CEST)
Message-ID: <cfb70e9e-6967-fed4-ea61-9a6078b4b27f@dawidek.net>
Date: Fri, 8 Sep 2023 17:27:52 -0700
List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-current
List-Help: <mailto:freebsd-current+help@freebsd.org>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Subscribe: <mailto:freebsd-current+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-current+unsubscribe@freebsd.org>
Sender: owner-freebsd-current@freebsd.org
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.0
Subject: Re: main [and, likely, stable/14]: do not set
 vfs.zfs.bclone_enabled=1 with that zpool feature enabled because it still
 leads to panics
Content-Language: en-US
To: Alexander Motin <mav@FreeBSD.org>, Martin Matuska <mm@FreeBSD.org>,
 Mark Millard <marklmi@yahoo.com>, Glen Barber <gjb@FreeBSD.org>
Cc: Current FreeBSD <freebsd-current@freebsd.org>,
 FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>
References: <7CE2CAAF-8BB0-4422-B194-4A6B0A4BC12C@yahoo.com>
 <08B7E72B-78F1-4ACA-B09D-E8C34BCE2335@yahoo.com>
 <20230907184823.GC4090@FreeBSD.org>
 <F4ED7034-6776-402C-8706-DED08F41455E@yahoo.com>
 <4f4e2b68-57e0-a475-e2bd-1f2b8844ebfe@FreeBSD.org>
 <354C5B8C-4216-4171-B8C2-8E827817F8E5@yahoo.com>
 <8B8B3707-4B37-4621-8124-D6A77CAF6879@yahoo.com>
 <15df58d3-4603-132f-112e-d10a6d4419bf@FreeBSD.org>
 <2a25427c-5a61-3f72-4e31-b7666741d38d@FreeBSD.org>
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
In-Reply-To: <2a25427c-5a61-3f72-4e31-b7666741d38d@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spamd-Bar: ----
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE]
X-Rspamd-Queue-Id: 4RjDN40Pplz3LjS

On 9/8/23 15:09, Alexander Motin wrote:
> Thank you, Martin.  I was able to reproduce the issue with your script 
> and found the cause.
> 
> I first though the issue is triggered by the `cp`, but it appeared to be 
> triggered by `cat`.  It also got copy_file_range() support, but later 
> than `cp`.  That is probably why it slipped through testing.  This patch 
> fixes it for me: https://github.com/openzfs/zfs/pull/15251 .
> 
> Mark, could you please try the patch?

Thank you Alex for the fix!

-- 
Pawel Jakub Dawidek