From nobody Fri Sep 08 22:30:41 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RjB7d0jK8z4sqYV; Fri, 8 Sep 2023 22:47:09 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from www541.your-server.de (www541.your-server.de [213.133.107.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RjB7c53Ydz4FHZ; Fri, 8 Sep 2023 22:47:08 +0000 (UTC) (envelope-from mm@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from sslproxy06.your-server.de ([78.46.172.3]) by www541.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qejzv-000LO3-HV; Sat, 09 Sep 2023 00:30:43 +0200 Received: from [188.167.171.2] (helo=[10.0.9.122]) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qejzu-000RYw-De; Sat, 09 Sep 2023 00:30:42 +0200 Message-ID: <63717d32-f340-1320-3335-85135d1b62bc@FreeBSD.org> Date: Sat, 9 Sep 2023 00:30:41 +0200 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: main [and, likely, stable/14]: do not set vfs.zfs.bclone_enabled=1 with that zpool feature enabled because it still leads to panics Content-Language: en-US To: Alexander Motin , Mark Millard , Glen Barber Cc: Current FreeBSD , FreeBSD-STABLE Mailing List , Pawel Jakub Dawidek References: <7CE2CAAF-8BB0-4422-B194-4A6B0A4BC12C@yahoo.com> <08B7E72B-78F1-4ACA-B09D-E8C34BCE2335@yahoo.com> <20230907184823.GC4090@FreeBSD.org> <4f4e2b68-57e0-a475-e2bd-1f2b8844ebfe@FreeBSD.org> <354C5B8C-4216-4171-B8C2-8E827817F8E5@yahoo.com> <8B8B3707-4B37-4621-8124-D6A77CAF6879@yahoo.com> <15df58d3-4603-132f-112e-d10a6d4419bf@FreeBSD.org> <2a25427c-5a61-3f72-4e31-b7666741d38d@FreeBSD.org> From: Martin Matuska In-Reply-To: <2a25427c-5a61-3f72-4e31-b7666741d38d@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated-Sender: martin@matuska.de X-Virus-Scanned: Clear (ClamAV 0.103.8/27025/Fri Sep 8 09:37:45 2023) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:213.133.96.0/19, country:DE] X-Rspamd-Queue-Id: 4RjB7c53Ydz4FHZ Hi Alexander, I can confirm that the patch fixes the panic caused by the provided script on my test systems. Mark, would it be possible to try poudriere on your system with a patched kernel? Thanks mm On 9. 9. 2023 0:09, Alexander Motin wrote: > On 08.09.2023 09:52, Martin Matuska wrote: >> I digged a little and was able to reproduce the panic without >> poudriere with a shell script. >> >> #!/bin/sh >> nl=' >> ' >> sed_script=s/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/ >> >> for ac_i in 1 2 3 4 5 6 7; do >>      sed_script="$sed_script$nl$sed_script" >> done >> echo "$sed_script" 2>/dev/null | sed 99q >conftest.sed >> >> repeats=8 >> count=0 >> echo -n 0123456789 >"conftest.in" >> while : >> do >>      cat "conftest.in" "conftest.in" >"conftest.tmp" >>      mv "conftest.tmp" "conftest.in" >>      cp "conftest.in" "conftest.nl" >>      echo '' >> "conftest.nl" >>      sed -f conftest.sed < "conftest.nl" >"conftest.out" 2>/dev/null >> || break >>      diff "conftest.out" "conftest.nl" >/dev/null 2>&1 || break >>      count=$(($count + 1)) >>      echo "count: $count" >>      # 10*(2^10) chars as input seems more than enough >>      test $count -gt $repeats && break >> done >> rm -f conftest.in conftest.tmp conftest.nl conftest.out > > Thank you, Martin.  I was able to reproduce the issue with your script > and found the cause. > > I first though the issue is triggered by the `cp`, but it appeared to > be triggered by `cat`.  It also got copy_file_range() support, but > later than `cp`.  That is probably why it slipped through testing.  > This patch fixes it for me: https://github.com/openzfs/zfs/pull/15251 . > > Mark, could you please try the patch? >