Re: byteswap.h not found on 12 and 13

From: Nuno Teixeira <eduardo_at_freebsd.org>
Date: Mon, 27 Mar 2023 12:59:08 UTC
Fixed at
https://cgit.freebsd.org/ports/commit/?id=fb22e1c2e3653558065ffa0509c3c020834723db

Thanks all,

Nuno Teixeira <eduardo@freebsd.org> escreveu no dia sexta, 24/03/2023 à(s)
11:15:

> I'm thinking in the best plan to patch port.
> What about patch it for OSVERSION < 14 that will fix 12 and 13 and when
> 13.2 is out patching it only for 12.
>
> Any thoughts?
>
> Warner Losh <imp@bsdimp.com> escreveu no dia sexta, 24/03/2023 à(s) 09:37:
>
>>
>>
>> On Fri, Mar 24, 2023 at 3:23 AM Floyd, Paul <paulf2718@gmail.com> wrote:
>>
>>>
>>> A modern and standard solution is std::byteswap.
>>>
>>> https://en.cppreference.com/w/cpp/numeric/byteswap
>>>
>>> According to this
>>>
>>> https://en.cppreference.com/w/cpp/compiler_support#C.2B.2B23_library_features
>>>
>>> you will need llvm 14 for that.
>>>
>>
>> Which doesn't help OP since they needed 12 and 13 support for existing
>> software.
>> Also, that's C++ only, which I don't think helps either.
>>
>> I'm glad to see some articulated standards here because when I did
>> endian.h
>> and byteswap.h, it was a minefield of what can or can't be defined in the
>> face
>> of existing use.
>>
>> Warner
>>
>>
>>> A+
>>>
>>> Paul
>>>
>>>
>>>
>>>
>>>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>


-- 
Nuno Teixeira
FreeBSD Committer (ports)