Re: byteswap.h not found on 12 and 13

From: Yuri <yuri_at_aetern.org>
Date: Fri, 24 Mar 2023 08:48:10 UTC
Nuno Teixeira wrote:
> Hello Warner,
> 
> My poudriere jails:
> ---
> 124amd64   12.4-RELEASE-p2      amd64         http         2023-03-17
> 08:04:15 /usr/local/poudriere/jails/124amd64
> 124i386    12.4-RELEASE-p2      i386          http         2023-03-17
> 08:04:38 /usr/local/poudriere/jails/124i386
> 131amd64   13.1-RELEASE-p7      amd64         http         2023-03-17
> 08:05:03 /usr/local/poudriere/jails/131amd64
> ---
> 
> The strange thing is that 5.08 (old version) have #include <byteswap.h>
> too and compiles fine|:
> |
> https://github.com/sflow/sflowtool/issues/41
> <https://github.com/sflow/sflowtool/issues/41>

5.08 seems to have it commented out:

sflowtool-5.08/src/sflowtool.c:

/*
#ifdef DARWIN
#include <architecture/byte_order.h>
#define bswap_16(x) NXSwapShort(x)
#define bswap_32(x) NXSwapInt(x)
#else
#include <byteswap.h>
#endif
*/


> Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>> escreveu no dia
> sexta, 24/03/2023 à(s) 08:30:
> 
> 
> 
>     On Fri, Mar 24, 2023, 9:23 AM Nuno Teixeira <eduardo@freebsd.org
>     <mailto:eduardo@freebsd.org>> wrote:
> 
>         Hello all,
> 
>         I'm getting a file not found on 12 and 13 compiling
>         net/sflowtool latest update:
>         It compile fine on 14.
> 
>         I've searched 14 src and found:
>         ---
>         ./include/byteswap.h
>         ./contrib/ofed/include/byteswap.h
>         ./contrib/llvm-project/libcxx/include/__bit/byteswap.h
>         ---
>         Any clues?
> 
> 
> 
>     I added it a short time ago. I thought I mfc'd it to 13 but not 12.
>     How recent a 13? It's a non standard glibc extension that may be in
>     the next posix standard though. I've not looked at the draft for it
>     yet to see if it complies or not.
> 
>     Warner
> 
>         Thanks,
> 
>         ---
>         ===>  Building for sflowtool-6.01
>         --- all ---
>         /usr/bin/make  all-recursive
>         --- all-recursive ---
>         Making all in src
>         --- sflowtool.o ---
>         cc -DHAVE_CONFIG_H -I. -I..      -O2 -pipe
>          -fstack-protector-strong -fno-strict-aliasing -MT sflowtool.o
>         -MD -MP -MF .deps/sflowtool.Tpo -c -o sflowtool.o sflowtool.c
>         sflowtool.c:32:10: fatal error: 'byteswap.h' file not found
>         #include <byteswap.h>
>                  ^~~~~~~~~~~~
>         1 error generated.
>         *** [sflowtool.o] Error code 1
>         ---
> 
> 
>         -- 
>         Nuno Teixeira
>         FreeBSD Committer (ports)
> 
> 
> 
> -- 
> Nuno Teixeira
> FreeBSD Committer (ports)