Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

From: José_Pérez <fbl_at_aoek.com>
Date: Mon, 17 Apr 2023 08:57:32 UTC 
Hi Pawel,
thank you for the patch.

Can you please elaborate a little more?

Did you run any tests? Is it safe to use your patch to access pools with 
feature@block_cloning active? Is it possible to build a kernel from such 
a pool?

Asking for others: is this fixing any corrupted data?

Thank you.

BR,

El 2023-04-17 06:35, Pawel Jakub Dawidek escribió:
> On 4/16/23 01:07, Florian Smeets wrote:
>> On the pool that has block_cloning enabled I see the above insta panic 
>> when poudriere starts building. I found a workaround though:
>> 
>> --- /usr/local/share/poudriere/include/fs.sh.orig    2023-04-15 
>> 18:03:50.090823000 +0200
>> +++ /usr/local/share/poudriere/include/fs.sh    2023-04-15 
>> 18:04:04.144736000 +0200
>> @@ -295,7 +295,6 @@
>>           fi
>> 
>>           zfs clone -o mountpoint=${mnt} \
>> -            -o sync=disabled \
>>               -o atime=off \
>>               -o compression=off \
>>               ${fs}@${snap} \
>> 
>> With this workaround I was able to build thousands of packages without 
>> panics or failures due to data corruption.
> 
> Thank you, Florian, that was very helpful!
> 
> This should fix the problem:
> 
> https://github.com/openzfs/zfs/pull/14758

-- 
José Pérez