From nobody Sat Sep 24 00:22:31 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MZ8qK0YxTz4dJqK for ; Sat, 24 Sep 2022 00:22:37 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MZ8qH6K1wz3vxj for ; Sat, 24 Sep 2022 00:22:35 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd36.google.com with SMTP id r134so1168684iod.8 for ; Fri, 23 Sep 2022 17:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=jgkSdylOfZaB9kzgswSnupJwGqKfDbo4Sw2lZTtqDJ4=; b=U0iCJZyybcA1m8NunMfBYw7FLXzhVxxlpII3KmwVhDY7JmNMJO4cqkXrVHhPMZ/gz0 gn36l8tMRD65Co+iSVPqnxZyvqxZsnfL2STQniby9b/rvzDfL8QpMmRu4vmLd5yvjVJB u+Ax9ud/K9LP1ZzylBzcr/Vs91HKj3HAAOh4mDzVfAXQUULPVOJ69YgPtXlbhAwvRZRx +JbNjwaE7AtdZSSSUvZxK+Mu3bVSpN0BdCd9+j3zrLXxUENssVU4Grr3ZQ9xK8VRIngx fSA/vsmgviHAIuQtkjsf4T6Jmfwla7P7rZgw2luLQZB43Zrx3Lt/lG7L3zRe6Choj8SN JeAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=jgkSdylOfZaB9kzgswSnupJwGqKfDbo4Sw2lZTtqDJ4=; b=ck+Fq60pWKAjYvbRJKLVayIDk/gobWiTFxX3CqkfGcBrcSZ6ANFYaoCeehOx0OvAT9 HAVrjqYvjgNGfCBBHC49lG5EfekGYsOQWEl/cvTtTGH5M+KYFc1eP3NYXphXuBusULb8 by7+uCx19fSTIznSzCHWEc5+aKl7ZvyI2phzXa6xiaoD3B+Va1xamCSWmUOHH35QYRsg cNhY5Dkl1rHJOmmh5DuqFpwvLxKow3JwfgqJYGtmZWSDbw2dC48ZOhNG5y+TJI49ZEPK 4X6Z4fU3BLN12tZevtzH4LhC0rMaVCdFCNoQwnzFeIOSovXsAhdjJzuzYi0pdcXaRETX pwPQ== X-Gm-Message-State: ACrzQf0s2+o62uviV4oUPgFyG+fmzhPgTd8PEQ+LoLJhOTQ/UHcBGi1E cc9NHqmb2AEqBmJKTuDbslH+gwl7svU= X-Google-Smtp-Source: AMsMyM7Tj2aZ2M06FnkjfpsRp3dn0JGstb7CkffZREq7RMhZv7bo7lU4KicLN7be2iMrRVFWtWgLWw== X-Received: by 2002:a6b:691d:0:b0:6a3:e87e:5aed with SMTP id e29-20020a6b691d000000b006a3e87e5aedmr4940251ioc.56.1663978954940; Fri, 23 Sep 2022 17:22:34 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id j21-20020a056638053500b0035a9b0050easm3972242jar.18.2022.09.23.17.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 17:22:34 -0700 (PDT) Date: Fri, 23 Sep 2022 20:22:31 -0400 From: Mark Johnston To: Steve Kargl Cc: freebsd-current@freebsd.org Subject: Re: A panic a day Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4MZ8qH6K1wz3vxj X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=U0iCJZyy; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d36 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d36:from]; DMARC_NA(0.00)[freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Fri, Sep 23, 2022 at 09:46:08AM -0700, Steve Kargl wrote: > On Thu, Sep 22, 2022 at 03:00:53PM -0400, Mark Johnston wrote: > > > > I think this untested patch will address the panics. The bug was there > > for a long time but some recent restructuring added an assertion which > > caught it. > > > > diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c > > index 9d48aa746f6d..484864b66c1c 100644 > > --- a/sys/kern/sched_4bsd.c > > +++ b/sys/kern/sched_4bsd.c > > @@ -1282,9 +1282,10 @@ kick_other_cpu(int pri, int cpuid) > > } > > #endif /* defined(IPI_PREEMPTION) && defined(PREEMPTION) */ > > > > - ast_sched_locked(pcpu->pc_curthread, TDA_SCHED); > > - ipi_cpu(cpuid, IPI_AST); > > - return; > > + if (pcpu->pc_curthread->td_lock == &sched_lock) { > > + ast_sched_locked(pcpu->pc_curthread, TDA_SCHED); > > + ipi_cpu(cpuid, IPI_AST); > > + } > > } > > #endif /* SMP */ > > > > @@ -1397,7 +1398,7 @@ sched_add(struct thread *td, int flags) > > > > cpuid = PCPU_GET(cpuid); > > if (single_cpu && cpu != cpuid) { > > - kick_other_cpu(td->td_priority, cpu); > > + kick_other_cpu(td->td_priority, cpu); > > } else { > > if (!single_cpu) { > > tidlemsk = idle_cpus_mask; > > Mark, > > My system has been running a fairly heavy load with this > patch for the last 20 or so hours without any incidences. > In fact, the system feels snappier. Thanks for the quick > response with a patch. Thanks, committed in c2d27b0ec700.