From nobody Tue Sep 13 06:34:03 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRYbB0zXSz4cdcJ for ; Tue, 13 Sep 2022 06:34:14 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRYb917Gmz3Mj4 for ; Tue, 13 Sep 2022 06:34:12 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1663050845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qby0C+jRiYNH3vL0prnKsZ1isEVhpAdv4Ag3xpO+JtU=; b=neQ2db7U1XCFYsqqQ3JAZLRAaOQvySIXx8v7K2/jUuxIJi1CB7jpB0YGw+MkdSjsWG8E30 S6vIQCi9K1RhxlhsAGuG7jcZv8U4ulNCiPbdLOnpe6GKdZk2jKrY2K9LIdZ8fdjijBYTna 7Une3sBuW4/cMntc61B2SxQWLlVQXtg= Received: from skull.home.blih.net ( [94.238.214.231]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 9dd2cd7c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 13 Sep 2022 06:34:05 +0000 (UTC) Date: Tue, 13 Sep 2022 08:34:03 +0200 From: Emmanuel Vadot To: Filipe da Silva Santos Cc: freebsd-current@FreeBSD.org Subject: Re: WITH_BHYVE_SNAPSHOT broken after 9cc9abf4 Message-Id: <20220913083403.800ee2bf1cbe115ad38c7aaa@bidouilliste.com> In-Reply-To: <86sfkw2nye.fsf@mail.shiori.com.br> References: <86sfkw2nye.fsf@mail.shiori.com.br> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4MRYb917Gmz3Mj4 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=neQ2db7U; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@FreeBSD.org]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[manu]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, 12 Sep 2022 23:05:29 +0000 Filipe da Silva Santos wrote: > int vcpu declared in line 1247 isn't being used, since it's now being > redefined inside the for loop in line 1589. > > diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c > index 550cc9d15..27f1d8ea8 100644 > --- a/usr.sbin/bhyve/bhyverun.c > +++ b/usr.sbin/bhyve/bhyverun.c > @@ -1244,7 +1244,6 @@ main(int argc, char *argv[]) > #ifdef BHYVE_SNAPSHOT > char *restore_file; > struct restore_state rstate; > - int vcpu; > > restore_file = NULL; > #endif Hello Filipe, Sorry for the breakage, should be fixed in 10c6af344108. -- Emmanuel Vadot